CVE-2022-34568: A USE AFTER FREE BUG · Issue #863 · libsdl-org/SDL-1.2

Fix would simply be moving XFree() a line below: @icculus, @slouken?

diff --git a/src/video/x11/SDL_x11yuv.c b/src/video/x11/SDL_x11yuv.c index 62698df…0d5754e 100644 — a/src/video/x11/SDL_x11yuv.c +++ b/src/video/x11/SDL_x11yuv.c @@ -374,8 +374,8 @@ SDL_Overlay *X11_CreateYUVOverlay(_THIS, int width, int height, Uint32 format, S #ifdef PITCH_WORKAROUND if ( hwdata->image != NULL && hwdata->image->pitches[0] != (width*bpp) ) { /* Ajust overlay width according to pitch */ - XFree(hwdata->image); width = hwdata->image->pitches[0] / bpp;

•       XFree(hwdata->image);
        hwdata->image = SDL\_NAME(XvCreateImage)(GFX\_Display, xv\_port, format,
                            0, width, height);
    }