Headline
CVE-2023-42809: Feature - allowedClasses setting added to SerializationCodec https://… · redisson/redisson@fe6a257
Redisson is a Java Redis client that uses the Netty framework. Prior to version 3.22.0, some of the messages received from the Redis server contain Java objects that the client deserializes without further validation. Attackers that manage to trick clients into communicating with a malicious server can include especially crafted objects in its responses that, once deserialized by the client, force it to execute arbitrary code. This can be abused to take control of the machine the client is running in. Version 3.22.0 contains a patch for this issue.
Some post-fix advice is available. Do NOT use Kryo5Codec
as deserialization codec, as it is still vulnerable to arbitrary object deserialization due to the setRegistrationRequired(false)
call. On the contrary, KryoCodec
is safe to use. The fix applied to SerializationCodec
only consists of adding an optional allowlist of class names, even though making this behavior the default is recommended. When instantiating SerializationCodec
please use the SerializationCodec(ClassLoader classLoader, Set<String> allowedClasses)
constructor to restrict the allowed classes for deserialization.
Expand Up
@@ -15,19 +15,19 @@
*/
package org.redisson.codec;
import java.io.IOException;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufAllocator;
import io.netty.buffer.ByteBufInputStream;
import io.netty.buffer.ByteBufOutputStream;
import org.redisson.client.codec.BaseCodec;
import org.redisson.client.handler.State;
import org.redisson.client.protocol.Decoder;
import org.redisson.client.protocol.Encoder;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufAllocator;
import io.netty.buffer.ByteBufInputStream;
import io.netty.buffer.ByteBufOutputStream;
import java.io.IOException;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.util.Set;
/**
* JDK’s serialization codec.
Expand All
@@ -51,7 +51,7 @@ public Object decode(ByteBuf buf, State state) throws IOException {
ObjectInputStream inputStream;
if (classLoader != null) {
Thread.currentThread().setContextClassLoader(classLoader);
inputStream = new CustomObjectInputStream(classLoader, in);
inputStream = new CustomObjectInputStream(classLoader, in, allowedClasses);
} else {
inputStream = new ObjectInputStream(in);
}
Expand Down Expand Up
@@ -84,7 +84,8 @@ public ByteBuf encode(Object in) throws IOException {
}
}
};
private Set<String> allowedClasses;
private final ClassLoader classLoader;
public SerializationCodec() {
Expand All
@@ -97,6 +98,12 @@ public SerializationCodec(ClassLoader classLoader) {
public SerializationCodec(ClassLoader classLoader, SerializationCodec codec) {
this.classLoader = classLoader;
this.allowedClasses = codec.allowedClasses;
}
public SerializationCodec(ClassLoader classLoader, Set<String> allowedClasses) {
this.classLoader = classLoader;
this.allowedClasses = allowedClasses;
}
@Override
Expand Down
Related news
Redisson is a Java Redis client that uses the Netty framework. Prior to version 3.22.0, some of the messages received from the Redis server contain Java objects that the client deserializes without further validation. Attackers that manage to trick clients into communicating with a malicious server can include especially crafted objects in its responses that, once deserialized by the client, force it to execute arbitrary code. This can be abused to take control of the machine the client is running in. Version 3.22.0 contains a patch for this issue. Some post-fix advice is available. Do NOT use `Kryo5Codec` as deserialization codec, as it is still vulnerable to arbitrary object deserialization due to the `setRegistrationRequired(false)` call. On the contrary, `KryoCodec` is safe to use. The fix applied to `SerializationCodec` only consists of adding an optional allowlist of class names, even though making this behavior the default is recommended. When instantiating `SerializationCodec`...