Headline
CVE-2022-35939: Check bounds for reads and writes in scatter_nd · tensorflow/tensorflow@b4d4b4c
TensorFlow is an open source platform for machine learning. The ScatterNd function takes an input argument that determines the indices of of the output tensor. An input index greater than the output tensor or less than zero will either write content at the wrong index or trigger a crash. We have patched the issue in GitHub commit b4d4b4cb019bd7240a52daa4ba61e3cc814f0384. The fix will be included in TensorFlow 2.10.0. We will also cherrypick this commit on TensorFlow 2.9.1, TensorFlow 2.8.1, and TensorFlow 2.7.2, as these are also affected and still in supported range. There are no known workarounds for this issue.
@@ -129,11 +129,10 @@ TfLiteStatus Prepare(TfLiteContext* context, TfLiteNode* node) { template <typename IndicesT, typename UpdatesT> TfLiteStatus ScatterNd(const TfLiteTensor* indices, const TfLiteTensor* updates, TfLiteTensor* output) { reference_ops::ScatterNd( return reference_ops::ScatterNd( GetTensorShape(indices), GetTensorData<IndicesT>(indices), GetTensorShape(updates), GetTensorData<UpdatesT>(updates), GetTensorShape(output), GetTensorData<UpdatesT>(output)); return kTfLiteOk; }
template <typename IndicesT> @@ -149,25 +148,36 @@ TfLiteStatus EvalScatterNd(TfLiteContext* context, const TfLiteTensor* indices, ResizeOutputTensor<IndicesT>(context, shape, output)); }
TfLiteStatus status = kTfLiteError; switch (updates->type) { case kTfLiteFloat32: return ScatterNd<IndicesT, float>(indices, updates, output); status = ScatterNd<IndicesT, float>(indices, updates, output); break; case kTfLiteUInt8: return ScatterNd<IndicesT, uint8_t>(indices, updates, output); status = ScatterNd<IndicesT, uint8_t>(indices, updates, output); break; case kTfLiteBool: return ScatterNd<IndicesT, bool>(indices, updates, output); status = ScatterNd<IndicesT, bool>(indices, updates, output); break; case kTfLiteInt8: return ScatterNd<IndicesT, int8_t>(indices, updates, output); status = ScatterNd<IndicesT, int8_t>(indices, updates, output); break; case kTfLiteInt32: return ScatterNd<IndicesT, int32_t>(indices, updates, output); status = ScatterNd<IndicesT, int32_t>(indices, updates, output); break; case kTfLiteInt64: return ScatterNd<IndicesT, int64_t>(indices, updates, output); status = ScatterNd<IndicesT, int64_t>(indices, updates, output); break; default: TF_LITE_KERNEL_LOG( context, "Updates of type ‘%s’ are not supported by scatter_nd.", TfLiteTypeGetName(updates->type)); return kTfLiteError; } if (status != kTfLiteOk) { TF_LITE_KERNEL_LOG(context, “scatter_nd index out of bounds”); } return status; }
TfLiteStatus Eval(TfLiteContext* context, TfLiteNode* node) {
Related news
### Impact The [`ScatterNd`](https://github.com/tensorflow/tensorflow/blob/266558ac4c1f361e9a178ee9d3f0ce2e648ae499/tensorflow/lite/kernels/internal/reference/reference_ops.h#L659-L698) function takes an input argument that determines the indices of of the output tensor. An input index greater than the output tensor or less than zero will either write content at the wrong index or trigger a crash. ### Patches We have patched the issue in GitHub commit [b4d4b4cb019bd7240a52daa4ba61e3cc814f0384](https://github.com/tensorflow/tensorflow/commit/b4d4b4cb019bd7240a52daa4ba61e3cc814f0384). The fix will be included in TensorFlow 2.10.0. We will also cherrypick this commit on TensorFlow 2.9.1, TensorFlow 2.8.1, and TensorFlow 2.7.2, as these are also affected and still in supported range. ### For more information Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with i...