Headline
CVE-2022-46604: ResponsiveFilemanager/execute.php at v9.9.5 · trippo/ResponsiveFilemanager
An issue in Tecrail Responsive FileManager v9.9.5 and below allows attackers to bypass the file extension check mechanism and upload a crafted PHP file, leading to arbitrary code execution.
<?php $config = include ‘config/config.php’; //TODO switch to array extract($config, EXTR_OVERWRITE); include ‘include/utils.php’; if ($_SESSION[‘RF’][“verify”] != “RESPONSIVEfilemanager”) { response(‘forbiden’, 403)->send(); exit; } $thumb_pos = strpos($_POST[‘path_thumb’], $thumbs_base_path); if ($thumb_pos !=0 || strpos($_POST[‘path_thumb’],’…/’,strlen($thumbs_base_path)+$thumb_pos)!==FALSE || strpos($_POST[‘path’],’/’)===0 || strpos($_POST[‘path’],’…/’)!==FALSE || strpos($_POST[‘path’],’./’)===0) { response(‘wrong path’)->send(); exit; } if (isset($_SESSION[‘RF’][‘language_file’]) && file_exists($_SESSION[‘RF’][‘language_file’])) { //TODO Very bad practice require_once $_SESSION[‘RF’][‘language_file’]; } else { response(‘Language file is missing!’, 500)->send(); exit; } $base = $current_path; $path = $current_path.$_POST[‘path’]; $cycle = TRUE; $max_cycles = 50; $i = 0; while($cycle && $i<$max_cycles) { $i++; if ($path == $base) $cycle=FALSE; if (file_exists($path."config.php")) { require_once $path."config.php"; $cycle = FALSE; } $path = fix_dirname($path)."/"; $cycle = FALSE; } $path = $current_path.$_POST[‘path’]; $path_thumb = $_POST[‘path_thumb’]; if (isset($_POST[‘name’])) { $name = fix_filename($_POST[‘name’],$transliteration,$convert_spaces, $replace_with); if (strpos($name,’…/’) !== FALSE) { response(‘wrong name’, 400)->send(); exit; } } $info = pathinfo($path); if (isset($info[‘extension’]) && !(isset($_GET[‘action’]) && $_GET[‘action’]==’delete_folder’) && !in_array(strtolower($info[‘extension’]), $ext) && $_GET[‘action’] != ‘create_file’) { response('wrong extension’, 400)->send(); exit; } if (isset($_GET[‘action’])) { switch($_GET[‘action’]) { case 'delete_file’: if ($delete_files){ unlink($path); if (file_exists($path_thumb)) unlink($path_thumb); $info=pathinfo($path); if ($relative_image_creation){ foreach($relative_path_from_current_pos as $k=>$path) { if ($path!="" && $path[strlen($path)-1]!="/") $path.="/"; if (file_exists($info[‘dirname’]."/".$path.$relative_image_creation_name_to_prepend[$k].$info[‘filename’].$relative_image_creation_name_to_append[$k].".".$info[‘extension’])) { unlink($info[‘dirname’]."/".$path.$relative_image_creation_name_to_prepend[$k].$info[‘filename’].$relative_image_creation_name_to_append[$k].".".$info[‘extension’]); } } } if ($fixed_image_creation) { foreach($fixed_path_from_filemanager as $k=>$path) { if ($path!="" && $path[strlen($path)-1] != “/”) $path.="/"; $base_dir=$path.substr_replace($info[‘dirname’]."/", '’, 0, strlen($current_path)); if (file_exists($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’])) { unlink($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’]); } } } } break; case 'delete_folder’: if ($delete_folders){ if (is_dir($path_thumb)) { deleteDir($path_thumb); } if (is_dir($path)) { deleteDir($path); if ($fixed_image_creation) { foreach($fixed_path_from_filemanager as $k=>$paths){ if ($paths!="" && $paths[strlen($paths)-1] != “/”) $paths.="/"; $base_dir=$paths.substr_replace($path, '’, 0, strlen($current_path)); if (is_dir($base_dir)) deleteDir($base_dir); } } } } break; case 'create_folder’: if ($create_folders) { create_folder(fix_path($path,$transliteration,$convert_spaces, $replace_with),fix_path($path_thumb,$transliteration,$convert_spaces, $replace_with)); } break; case 'rename_folder’: if ($rename_folders){ $name=fix_filename($name,$transliteration,$convert_spaces, $replace_with); $name=str_replace('.’,’’,$name); if (!empty($name)){ if (!rename_folder($path,$name,$transliteration,$convert_spaces)) { response(trans(‘Rename_existing_folder’), 403)->send(); exit; } rename_folder($path_thumb,$name,$transliteration,$convert_spaces); if ($fixed_image_creation){ foreach($fixed_path_from_filemanager as $k=>$paths){ if ($paths!="" && $paths[strlen($paths)-1] != “/”) $paths.="/"; $base_dir=$paths.substr_replace($path, '’, 0, strlen($current_path)); rename_folder($base_dir,$name,$transliteration,$convert_spaces); } } } else { response(trans(‘Empty_name’), 400)->send(); exit; } } break; case ‘create_file’: if ($create_text_files === FALSE) { response(sprintf(trans(‘File_Open_Edit_Not_Allowed’), strtolower(trans(‘Edit’))), 403)->send(); exit; } if (!isset($editable_text_file_exts) || !is_array($editable_text_file_exts)){ $editable_text_file_exts = array(); } // check if user supplied extension if (strpos($name, ‘.’) === FALSE){ response(trans(‘No_Extension’).’ '.sprintf(trans(‘Valid_Extensions’), implode(', ', $editable_text_file_exts)), 400)->send(); exit; } // correct name $old_name = $name; $name=fix_filename($name,$transliteration,$convert_spaces, $replace_with); if (empty($name)) { response(trans(‘Empty_name’), 400)->send(); exit; } // check extension $parts = explode(‘.’, $name); if (!in_array(end($parts), $editable_text_file_exts)) { response(trans(‘Error_extension’).’ '.sprintf(trans(‘Valid_Extensions’), implode(', ', $editable_text_file_exts)), 400)->send(); exit; } // correct paths $path = str_replace($old_name, $name, $path); $path_thumb = str_replace($old_name, $name, $path_thumb); // file already exists if (file_exists($path)) { response(trans(‘Rename_existing_file’), 403)->send(); exit; } $content = $_POST[‘new_content’]; if (@file_put_contents($path, $content) === FALSE) { response(trans(‘File_Save_Error’), 500)->send(); exit; } else { if (is_function_callable(‘chmod’) !== FALSE){ chmod($path, 0644); } response(trans(‘File_Save_OK’))->send(); exit; } break; case 'rename_file’: if ($rename_files){ $name=fix_filename($name,$transliteration,$convert_spaces, $replace_with); if (!empty($name)) { if (!rename_file($path,$name,$transliteration)) { response(trans(‘Rename_existing_file’), 403)->send(); exit; } rename_file($path_thumb,$name,$transliteration); if ($fixed_image_creation) { $info=pathinfo($path); foreach($fixed_path_from_filemanager as $k=>$paths) { if ($paths!="" && $paths[strlen($paths)-1] != “/”) $paths.="/"; $base_dir = $paths.substr_replace($info[‘dirname’]."/", '’, 0, strlen($current_path)); if (file_exists($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’])) { rename_file($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’],$fixed_image_creation_name_to_prepend[$k].$name.$fixed_image_creation_to_append[$k],$transliteration); } } } } else { response(trans(‘Empty_name’), 400)->send(); exit; } } break; case 'duplicate_file’: if ($duplicate_files) { $name=fix_filename($name,$transliteration,$convert_spaces, $replace_with); if (!empty($name)) { if (!duplicate_file($path,$name)) { response(trans(‘Rename_existing_file’), 403)->send(); exit; } duplicate_file($path_thumb,$name); if ($fixed_image_creation) { $info=pathinfo($path); foreach($fixed_path_from_filemanager as $k=>$paths) { if ($paths!="" && $paths[strlen($paths)-1] != “/”) $paths.= "/"; $base_dir=$paths.substr_replace($info[‘dirname’]."/", '’, 0, strlen($current_path)); if (file_exists($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’])) { duplicate_file($base_dir.$fixed_image_creation_name_to_prepend[$k].$info[‘filename’].$fixed_image_creation_to_append[$k].".".$info[‘extension’],$fixed_image_creation_name_to_prepend[$k].$name.$fixed_image_creation_to_append[$k]); } } } } else { response(trans(‘Empty_name’), 400)->send(); exit; } } break; case 'paste_clipboard’: if ( ! isset($_SESSION[‘RF’][‘clipboard_action’], $_SESSION[‘RF’][‘clipboard’][‘path’], $_SESSION[‘RF’][‘clipboard’][‘path_thumb’]) || $_SESSION[‘RF’][‘clipboard_action’] == ‘’ || $_SESSION[‘RF’][‘clipboard’][‘path’] == ‘’ || $_SESSION[‘RF’][‘clipboard’][‘path_thumb’] == ‘’) { response()->send(); exit; } $action = $_SESSION[‘RF’][‘clipboard_action’]; $data = $_SESSION[‘RF’][‘clipboard’]; $data[‘path’] = $current_path.$data[‘path’]; $pinfo = pathinfo($data[‘path’]); // user wants to paste to the same dir. nothing to do here… if ($pinfo[‘dirname’] == rtrim($path, ‘/’)) { response()->send(); exit; } // user wants to paste folder to it’s own sub folder… baaaah. if (is_dir($data[‘path’]) && strpos($path, $data[‘path’]) !== FALSE){ response()->send(); exit; } // something terribly gone wrong if ($action != ‘copy’ && $action != ‘cut’){ response('no action’, 400)->send(); exit; } // check for writability if (is_really_writable($path) === FALSE || is_really_writable($path_thumb) === FALSE){ response(trans(‘Dir_No_Write’).’<br/>’.str_replace('…/’,’’,$path).’<br/>’.str_replace('…/’,’’,$path_thumb), 403)->send(); exit; } // check if server disables copy or rename if (is_function_callable(($action == ‘copy’ ? ‘copy’ : ‘rename’)) === FALSE){ response(sprintf(trans(‘Function_Disabled’), ($action == ‘copy’ ? lcfirst(trans(‘Copy’)) : lcfirst(trans(‘Cut’)))), 403)->send(); exit; } if ($action == ‘copy’) { rcopy($data[‘path’], $path); rcopy($data[‘path_thumb’], $path_thumb); } elseif ($action == ‘cut’) { rrename($data[‘path’], $path); rrename($data[‘path_thumb’], $path_thumb); // cleanup if (is_dir($data[‘path’]) === TRUE){ rrename_after_cleaner($data[‘path’]); rrename_after_cleaner($data[‘path_thumb’]); } } // cleanup $_SESSION[‘RF’][‘clipboard’][‘path’] = NULL; $_SESSION[‘RF’][‘clipboard’][‘path_thumb’] = NULL; $_SESSION[‘RF’][‘clipboard_action’] = NULL; break; case 'chmod’: $mode = $_POST[‘new_mode’]; $rec_option = $_POST[‘is_recursive’]; $valid_options = array('none’, 'files’, 'folders’, ‘both’); $chmod_perm = (is_dir($path) ? $chmod_dirs : $chmod_files); // check perm if ($chmod_perm === FALSE) { response(sprintf(trans(‘File_Permission_Not_Allowed’), (is_dir($path) ? lcfirst(trans(‘Folders’)) : lcfirst(trans(‘Files’)) )), 403)->send(); exit; } // check mode if (!preg_match("/^[0-7]{3}$/", $mode)){ response(trans(‘File_Permission_Wrong_Mode’), 400)->send(); exit; } // check recursive option if (!in_array($rec_option, $valid_options)){ response("wrong option", 400)->send(); exit; } // check if server disabled chmod if (is_function_callable(‘chmod’) === FALSE){ response(sprintf(trans(‘Function_Disabled’), ‘chmod’), 403)->send(); exit; } $mode = "0".$mode; $mode = octdec($mode); rchmod($path, $mode, $rec_option); break; case 'save_text_file’: $content = $_POST[‘new_content’]; // $content = htmlspecialchars($content); not needed // $content = stripslashes($content); // no file if (!file_exists($path)) { response(trans(‘File_Not_Found’), 404)->send(); exit; } // not writable or edit not allowed if (!is_writable($path) || $edit_text_files === FALSE) { response(sprintf(trans(‘File_Open_Edit_Not_Allowed’), strtolower(trans(‘Edit’))), 403)->send(); exit; } if (@file_put_contents($path, $content) === FALSE) { response(trans(‘File_Save_Error’), 500)->send(); exit; } else { response(trans(‘File_Save_OK’))->send(); exit; } break; default: response('wrong action’, 400)->send(); exit; } }