Headline
CVE-2022-35946: Filter allowed methods in plugin form controller · glpi-project/glpi@f542ec8
GLPI stands for Gestionnaire Libre de Parc Informatique and is a Free Asset and IT Management Software package, that provides ITIL Service Desk features, licenses tracking and software auditing. In affected versions request input is not properly validated in the plugin controller and can be used to access low-level API of Plugin class. An attacker can, for instance, alter database data.
Attacker must have “General setup” update rights to be able to perform this attack. Users are advised to upgrade to version 10.0.3. Users unable to upgrade should remove the front/plugin.form.php script.
@@ -43,16 +43,28 @@
$plugin = new Plugin();
if (
isset($_POST[‘action’])
&& isset($_POST[‘id’])
) {
if (method_exists($plugin, $_POST[‘action’])) {
call_user_func([$plugin, $_POST[‘action’]], $_POST[‘id’]);
} else {
echo "Action " . $_POST[‘action’] . " undefined";
}
Html::back();
$id = isset($_POST[‘id’]) && is_numeric($_POST[‘id’]) ? (int)$_POST[‘id’] : null;
$action = $id > 0 && isset($_POST[‘action’]) ? $_POST[‘action’] : null;
switch ($action) {
case 'install’:
$plugin->install($id);
break;
case 'activate’:
$plugin->activate($id);
break;
case 'unactivate’:
$plugin->unactivate($id);
break;
case 'uninstall’:
$plugin->uninstall($id);
break;
case 'clean’:
$plugin->clean($id);
break;
default:
Html::displayErrorAndDie(‘Lost’);
break;
}
Html::displayErrorAndDie(‘Lost’);
Html::back();