Headline
CVE-2023-38699: Fix 'Call to requests with verify=False disabling SSL certificate checks, security issue.' issue in mindsdb\integrations\handlers\dremio_handler\dremio_handler.py
MindsDB’s AI Virtual Database allows developers to connect any AI/ML model to any datasource. Prior to version 23.7.4.0, a call to requests with verify=False
disables SSL certificate checks. This rule enforces always verifying SSL certificates for methods in the Requests library. In version 23.7.4.0, certificates are validated by default, which is the desired behavior.
Summary
Found an issue: Call to requests with verify=False disabling SSL certificate checks, security issue. Make the impact and severity as straightforward as possible. This rule enforces always verifying SSL certificates for methods in the Requests library. Certificates are validated by default which is the desired behavior.
Encryption in general is typically critical to the security of many applications. Using TLS can significantly increase security by guaranteeing the identity of the party you are communicating with. This is accomplished by one or both parties presenting trusted certificates during the connection initialization phase of TLS.
Example of insecure code:
import requests
requests.get('https://www.openstack.org/’, verify=False)
Example of secure code:
import requests
requests.get('https://www.openstack.org/’, verify=True)
It is important to note that modules such as httplib within the Python standard library did not verify certificate chains until it was fixed in 2.7.9 release.
Details
Severity: Critical