Headline
CVE-2023-39962: files_external: getStorage before remove by ArtificialOwl · Pull Request #39323 · nextcloud/server
Nextcloud Server provides data storage for Nextcloud, an open source cloud platform. Starting in version 19.0.0 and prior to versions 19.0.13.10, 20.0.14.15, 21.0.9.13, 22.2.10.14, 23.0.12.8, 24.0.12.5, 25.0.9, 26.0.4, and 27.0.1, a malicious user could delete any personal or global external storage, making them inaccessible for everyone else as well. Nextcloud server versions 25.0.9, 26.0.4, and 27.0.1 and Nextcloud Enterprise Server versions 19.0.13.10, 20.0.14.15, 21.0.9.13, 22.2.10.14, 23.0.12.9, 24.0.12.5, 25.0.9, 26.0.4, and 27.0.1 contain a patch for this issue. As a workaround, disable app files_external. This also makes the external storage inaccessible but retains the configurations until a patched version has been deployed.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maxence Lange [email protected]
@@ -143,4 +143,10 @@
protected function isApplicable(StorageConfig $config) {
return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
}
public function removeStorage($id) {
Check notice
Code scanning / Psalm
MissingReturnType Note
Method OCA\Files_External\Service\UserStoragesService::removeStorage does not have a return type, expecting void
This was referenced
Jul 13, 2023
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This was referenced
Jul 13, 2023
The backport to stable24 failed. Please do this backport manually.
Switch to the target branch and update it
git checkout stable24 git pull origin stable24
Create the new backport branch
git checkout -b fix/foo-stable24
Cherry pick the change from the commit sha1 of the change against the default branch
This might cause conflicts. Resolve them.
git cherry-pick abc123
Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24
More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport
The backport to stable23 failed. Please do this backport manually.
Switch to the target branch and update it
git checkout stable23 git pull origin stable23
Create the new backport branch
git checkout -b fix/foo-stable23
Cherry pick the change from the commit sha1 of the change against the default branch
This might cause conflicts. Resolve them.
git cherry-pick abc123
Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23
More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport
Reviewers
AndyScherzinger AndyScherzinger approved these changes
Fenn-CS Fenn-CS approved these changes
icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend
come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend
nickvergessen Awaiting requested review from nickvergessen