Headline

GHSA-fg4q-ccq8-3r5q: NHibernate SQL injection vulnerability in discriminator mappings, static fields referenced in HQL, and some utilities

Impact

A SQL injection vulnerability exists in some types implementing ILiteralType.ObjectToSQLString. Callers of these methods are exposed to the vulnerability, which includes:

Mappings using inheritance with discriminator values:
- The discriminator value could be written in the mapping in a way exploiting the vulnerability of the associated discriminator type, if that type is among the vulnerable ones.
- The current culture settings for formatting the discriminator value type could be altered in a way resulting into SQL injections with the discriminator values.
HQL queries referencing a static field of the application.
Users of the SqlInsertBuilder and SqlUpdateBuilder utilities, calling their AddColumn overload taking a literal value. These overloads are unused by NHibernate but could be used by users referencing directly these utilities.
Any direct use of the ObjectToSQLString methods for building SQL queries on the user side.

Patches

Releases 5.4.9 and 5.5.2.

Workarounds

Ensure the application does not use the features listed above.
For discriminator usages, ensure the discriminator values in the mappings do not contain quotes for string discriminators. Furthermore, for types which ToString conversion can be altered to include SQL injections through adequate hacking of the current culture settings, either change for another type, or ensure the used values cannot allow culture exploits, or ensure the application performs sanity checks of the current culture settings. Types sensitive to culture include integers for negative values, dates, times and datetimes, floats and decimals.

References

#3516
#3517
#3547

4 months ago

ghsa

Open in Source

#sql #vulnerability #git

Navigation Menu

- Actions
  
  Automate any workflow
- Packages
  
  Host and manage packages
- Security
  
  Find and fix vulnerabilities
- Codespaces
  
  Instant dev environments
- GitHub Copilot
  
  Write better code with AI
- Code review
  
  Manage code changes
- Issues
  
  Plan and track work
- Discussions
  
  Collaborate outside of code

- GitHub Sponsors
  
  Fund open source developers

*   The ReadME Project
    
    GitHub community articles

- Enterprise platform
  
  AI-powered developer platform

Pricing

Provide feedback

Saved searches****Use saved searches to filter your results more quickly

GitHub Advisory Database
GitHub Reviewed
CVE-2024-39677

NHibernate SQL injection vulnerability in discriminator mappings, static fields referenced in HQL, and some utilities

Moderate severity GitHub Reviewed Published Jul 6, 2024 in nhibernate/nhibernate-core • Updated Jul 8, 2024

Package

nuget NHibernate (NuGet)

Affected versions

< 5.4.9

>= 5.5.0, < 5.5.2

Patched versions

5.4.9

5.5.2

Description

Impact

A SQL injection vulnerability exists in some types implementing ILiteralType.ObjectToSQLString. Callers of these methods are exposed to the vulnerability, which includes:

Mappings using inheritance with discriminator values:
- The discriminator value could be written in the mapping in a way exploiting the vulnerability of the associated discriminator type, if that type is among the vulnerable ones.
- The current culture settings for formatting the discriminator value type could be altered in a way resulting into SQL injections with the discriminator values.
HQL queries referencing a static field of the application.
Users of the SqlInsertBuilder and SqlUpdateBuilder utilities, calling their AddColumn overload taking a literal value. These overloads are unused by NHibernate but could be used by users referencing directly these utilities.
Any direct use of the ObjectToSQLString methods for building SQL queries on the user side.

Patches

Releases 5.4.9 and 5.5.2.

Workarounds

Ensure the application does not use the features listed above.
For discriminator usages, ensure the discriminator values in the mappings do not contain quotes for string discriminators. Furthermore, for types which ToString conversion can be altered to include SQL injections through adequate hacking of the current culture settings, either change for another type, or ensure the used values cannot allow culture exploits, or ensure the application performs sanity checks of the current culture settings. Types sensitive to culture include integers for negative values, dates, times and datetimes, floats and decimals.

References