Headline
GHSA-qp29-wcc2-vmpc: Silverstripe HtmlEditor embed url sanitisation
“Add from URL” doesn’t clearly sanitise URL server side
HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media “from a URL” (i.e. via oembed).
This action gets the URL to add in the GET parameter FileURL. However it doesn’t do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it’s possible future changes would break this.
Skip to content
Navigation Menu
Actions
Automate any workflow
Packages
Host and manage packages
Security
Find and fix vulnerabilities
Codespaces
Instant dev environments
Copilot
Write better code with AI
Code review
Manage code changes
Issues
Plan and track work
Discussions
Collaborate outside of code
GitHub Sponsors
Fund open source developers
* The ReadME Project
GitHub community articles
- Pricing
Provide feedback
Saved searches****Use saved searches to filter your results more quickly
Sign up
- GitHub Advisory Database
- GitHub Reviewed
- GHSA-qp29-wcc2-vmpc
Silverstripe HtmlEditor embed url sanitisation
Moderate severity GitHub Reviewed Published May 23, 2024 to the GitHub Advisory Database • Updated May 23, 2024
Package
composer silverstripe/framework (Composer)
Affected versions
>= 3.0.0, < 3.2.1
Description
Published to the GitHub Advisory Database
May 23, 2024
Last updated
May 23, 2024