GHSA-27wg-99g8-2v4v: Rust EVM erroneousle handles `record_external_operation` error return

Skip to content

• • Actions

    Automate any workflow

  • Packages

    Host and manage packages

  • Security

    Find and fix vulnerabilities

  • Codespaces

    Instant dev environments

  • Copilot

    Write better code with AI

  • Code review

    Manage code changes

  • Issues

    Plan and track work

  • Discussions

    Collaborate outside of code

• • GitHub Sponsors

    Fund open source developers

*   The ReadME Project
    
    GitHub community articles

• Pricing

1. GitHub Advisory Database
2. GitHub Reviewed
3. CVE-2024-21629

Rust EVM erroneousle handles `record_external_operation` error return

Moderate severity GitHub Reviewed Published Jan 2, 2024 in rust-ethereum/evm

Package

Affected versions

<= 0.41.0

Description

Impact

In rust-evm, a feature called record_external_operation was introduced, allowing library users to record custom gas changes. This feature can have some bogus interactions with the call stack.

In particular, during finalization of a CREATE or CREATE2, in the case that the substack execution happens successfully, rust-evm will first commit the substate, and then call record_external_operation(Write(out_code.len())). If record_external_operation later fails, this error is returned to the parent call stack, instead of Succeeded. Yet, the substate commitment already happened. This causes smart contracts able to commit state changes, when the parent caller contract receives zero address (which usually indicates that the execution has failed).

This issue only impacts library users with custom record_external_operation that returns errors.

Patches

The issue is patched in release 0.41.1. The commit can be seem here.

Workarounds

None.

References

Patch PR #264.

References

• GHSA-27wg-99g8-2v4v
• https://nvd.nist.gov/vuln/detail/CVE-2024-21629
• rust-ethereum/evm#264
• rust-ethereum/evm@d8991ec
• https://github.com/rust-ethereum/evm/blob/release-v041/src/executor/stack/executor.rs#L1012C25-L1012C69

Published to the GitHub Advisory Database

Jan 3, 2024