Headline
GHSA-v858-922f-fj9v: SimpleSAMLphp Link Injection vulnerability
Background
Several scripts part of SimpleSAMLphp display a web page with links obtained from the request parameters. This allows us to enhance usability, as the users are presented with links they can follow after completing a certain action, like logging out.
Description
The following scripts were not checking the URLs obtained via the HTTP request before displaying them as the target of links that the user may click on:
- www/logout.php
- modules/core/www/no_cookie.php The issue allowed attackers to display links targeting a malicious website inside a trusted site running SimpleSAMLphp, due to the lack of security checks involving the link_href and retryURL HTTP parameters, respectively. The issue was resolved by including a verification of the URLs received in the request against a white list of websites specified in the trusted.url.domains configuration option.
Affected versions
All SimpleSAMLphp versions prior to 1.14.4.
Impact
A remote attacker could craft a link pointing to a trusted website running SimpleSAMLphp, including a parameter pointing to a malicious website, and try to fool the victim into visiting that website by clicking on a link in the page presented by SimpleSAMLphp.
- GitHub Advisory Database
- GitHub Reviewed
- GHSA-v858-922f-fj9v
SimpleSAMLphp Link Injection vulnerability
Moderate severity GitHub Reviewed Published May 28, 2024 to the GitHub Advisory Database
Package
composer simplesamlphp/simplesamlphp (Composer)
Affected versions
< 1.14.4
Background
Several scripts part of SimpleSAMLphp display a web page with links obtained from the request parameters. This allows us to enhance usability, as the users are presented with links they can follow after completing a certain action, like logging out.
Description
The following scripts were not checking the URLs obtained via the HTTP request before displaying them as the target of links that the user may click on:
- www/logout.php
- modules/core/www/no_cookie.php
The issue allowed attackers to display links targeting a malicious website inside a trusted site running SimpleSAMLphp, due to the lack of security checks involving the link_href and retryURL HTTP parameters, respectively. The issue was resolved by including a verification of the URLs received in the request against a white list of websites specified in the trusted.url.domains configuration option.
Affected versions
All SimpleSAMLphp versions prior to 1.14.4.
Impact
A remote attacker could craft a link pointing to a trusted website running SimpleSAMLphp, including a parameter pointing to a malicious website, and try to fool the victim into visiting that website by clicking on a link in the page presented by SimpleSAMLphp.
References
- simplesamlphp/simplesamlphp@b1af4e4
- simplesamlphp/simplesamlphp@d26eb8f
- https://github.com/FriendsOfPHP/security-advisories/blob/master/simplesamlphp/simplesamlphp/201606-01.yaml
- https://simplesamlphp.org/security/201606-01
Published to the GitHub Advisory Database
May 28, 2024