Headline

CVE-2023-39652: [CVE-2023-39652] Improper neutralization of SQL parameter in Theme Volty Video Tab module for PrestaShop

theme volty tvcmsvideotab up to v4.0.0 was discovered to contain a SQL injection vulnerability via the component TvcmsVideoTabConfirmDeleteModuleFrontController::run().

1 year ago

CVE

Open in Source

#sql #vulnerability #web #php #auth

In the module “Theme Volty Video Tab” (tvcmsvideotab) up to version 4.0.0 from Theme Volty for PrestaShop, a guest can perform SQL injection in affected versions.

Summary

CVE ID: CVE-2023-39652
Published at: 2023-08-24
Platform: PrestaShop
Product: tvcmsvideotab
Impacted release: <= 4.0.0 (4.0.1 fixed the vulnerability)
Product author: Theme Volty
Weakness: CWE-89
Severity: critical (9.8)

Description

The methods TvcmsVideoTabConfirmDeleteModuleFrontController::run() and TvcmsVideoTabSaveVideoModuleFrontController::run() has sensitive SQL calls that can be executed with a trivial http call and exploited to forge a SQL injection.

This exploit uses a PrestaShop front controller and most attackers can conceal the module controller’s path during the exploit, so you will never know within your conventional frontend logs that it exploits this vulnerability. You will only see “POST /” inside your conventional frontend logs. Activating the AuditEngine of mod_security (or similar) is the only way to get data to confirm this exploit.

CVSS base metrics

Attack vector: network
Attack complexity: low
Privilege required: none
User interaction: none
Scope: unchanged
Confidentiality: high
Integrity: high
Availability: high

Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Possible malicious usage

Obtain admin access
Remove data from the associated PrestaShop
Copy/paste data from sensitive tables to FRONT to expose tokens and unlock admins’s ajax scripts
Rewrite SMTP settings to hijack emails

Patch from 4.0.0

--- 4.0.0/tvcmsvideotab/controllers/front/confirmdelete.php
+++ 4.0.1/tvcmsvideotab/controllers/front/confirmdelete.php
class TvcmsVideoTabConfirmDeleteModuleFrontController extends ModuleFrontController
{
    /**
     * @see FrontController::postProcess()
     */
    public function run()
    {
        $db = Db::getInstance(_PS_USE_SQL_SLAVE_);
    -   $id_product = Tools::getValue('id');
    +   $id_product = (int) Tools::getValue('id');
    -   $id_lang = Tools::getValue('id_lang');
    +   $id_lang = (int) Tools::getValue('id_lang');
        $id_shop = $this->context->shop->id;
    }
}


--- 4.0.0/tvcmsvideotab/controllers/front/savevideo.php
+++ XXXXX/tvcmsvideotab/controllers/front/savevideo.php
class TvcmsVideoTabSaveVideoModuleFrontController extends ModuleFrontController
{
    public function run()
    {
        $ok = '';
        $id_lang_default = Configuration::get('PS_LANG_DEFAULT');
        $ob_lang_default = new Language($id_lang_default);
        $name_lang_default = $ob_lang_default->name;
-       $id_shop = Tools::getValue('id_shop');
+       $id_shop = (int) Tools::getValue('id_shop');
-       $name_shop = Tools::getValue('name_shop');
+       $name_shop = pSQL(Tools::getValue('name_shop'));
        $db = Db::getInstance(_PS_USE_SQL_SLAVE_);
        $url = $_SERVER['SCRIPT_FILENAME'];
        $url = rtrim($url, 'index.php');
        $languages = Language::getLanguages();
-       $type_video = Tools::getValue('type_video');
+       $type_video = pSQL(Tools::getValue('type_video'));
-       $id_product = Tools::getValue('id_product');
+       $id_product = (int) Tools::getValue('id_product');
...
                        $sql = 'REPLACE INTO ' . _DB_PREFIX_ . 'url_video ';
                        $sql .= '(id_video,id_product,id_store,text_url,language,shop,name_product,type,id_lang)';
                        $sql .= " VALUES ('" . $id_video . "','" . $id_product . "','" . $id_shop . "','";
-                       $sql .= '' . trim($name_url_array[$value_lang['id_lang']]) . "','" . $value_lang['name'] . "','";
+                       $sql .= '' . pSQL(trim($name_url_array[$value_lang['id_lang']])) . "','" . $value_lang['name'] . "','";
...
                        $sql = 'REPLACE INTO ' . _DB_PREFIX_ . 'url_video ';
                        $sql .= '(id_video,id_product,id_store,text_url,language,shop,name_product,type,id_lang)';
                        $sql .= " VALUES ('" . $id_video . "','" . $id_product . "','" . $id_shop . "','";
-                       $sql .= '' . trim($name_url_array[$value_lang['id_lang']]) . "','" . $value_lang['name'] . "','";
+                       $sql .= '' . pSQL(trim($name_url_array[$value_lang['id_lang']])) . "','" . $value_lang['name'] . "','";
...
                        $sql = 'REPLACE INTO ' . _DB_PREFIX_ . 'url_video ';
                        $sql .= '(id_video,id_product,id_store,text_url,language,shop,name_product,type,id_lang)';
                        $sql .= " VALUES ('" . $id_video . "','" . $id_product . "','" . $id_shop . "','";
-                       $sql .= '' . trim($name_url_array[$value_lang['id_lang']]) . "','" . $value_lang['name'] . "','";
+                       $sql .= '' . pSQL(trim($name_url_array[$value_lang['id_lang']])) . "','" . $value_lang['name'] . "','";

Other recommendations

It’s recommended to upgrade to the latest version of the module tvcmsvideotab.
Upgrade PrestaShop to the latest version to disable multiquery executions (separated by “;”) - be warned that this functionality WILL NOT protect your SHOP against injection SQL which uses the UNION clause to steal data.
Change the default database prefix ps_ with a new longer, arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skills because of a design vulnerability in DBMS
Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against this set of rules.

Timeline

Date

Action

2023-02-10

Issue discovered during a code review by TouchWeb.fr

2023-02-10

Contact PrestaShop Addons security Team to confirm versions scope by author

2023-02-15

Author provide a patch which still own all criticals vulnerabilities

2023-04-13

Recontact PrestaShop Addons security Team to confirm versions scope by author

2023-04-13