Headline
CVE-2022-24900: Merge pull request #351 from porcupineyhairs/FixPathInjection · onlaj/Piano-LED-Visualizer@3f10602
Piano LED Visualizer is software that allows LED lights to light up as a person plays a piano connected to a computer. Version 1.3 and prior are vulnerable to a path traversal attack. The os.path.join call is unsafe for use with untrusted input. When the os.path.join call encounters an absolute path, it ignores all the parameters it has encountered till that point and starts working with the new absolute path. Since the “malicious” parameter represents an absolute path, the result of os.path.join ignores the static directory completely. Hence, untrusted input is passed via the os.path.join call to flask.send_file can lead to path traversal attacks. A patch with a fix is available on the master branch of the GitHub repository. This can also be fixed by preventing flow of untrusted data to the vulnerable send_file function. In case the application logic necessiates this behaviour, one can either use the flask.safe_join to join untrusted paths or replace flask.send_file calls with flask.send_from_directory calls.
@@ -1,5 +1,6 @@
from webinterface import webinterface
from flask import render_template, send_file, redirect, request, url_for, jsonify
from werkzeug.utils import safe_join
from lib.functions import find_between, theaterChase, theaterChaseRainbow, sound_of_da_police, scanner, breathing, \
rainbow, rainbowCycle, fastColorWipe, play_midi, clamp
import psutil
Expand Down Expand Up
@@ -967,7 +968,7 @@ def change_setting():
return send_file(“…/Songs/” + value.replace(".mid", “”) + ".zip", mimetype=’application/x-csv’,
attachment_filename=value.replace(".mid", “”) + ".zip", as_attachment=True)
else:
return send_file(“…/Songs/” + value, mimetype=’application/x-csv’, attachment_filename=value,
return send_file(safe_join(“…/Songs/” + value), mimetype=’application/x-csv’, attachment_filename=value,
as_attachment=True)
if setting_name == "download_sheet_music":
Expand All
@@ -982,7 +983,7 @@ def change_setting():
i += 1
webinterface.learning.convert_midi_to_abc(value)
try:
return send_file(“…/Songs/” + value.replace(".mid", “.abc”), mimetype=’application/x-csv’,
return send_file(safe_join("…/Songs/", value.replace(".mid", “.abc”)), mimetype=’application/x-csv’,
attachment_filename=value.replace(".mid", “.abc”), as_attachment=True)
except:
print(“Converting failed”)
Expand Down