CVE-2019-11486: tty: mark Siemens R3964 line discipline as BROKEN · torvalds/linux@c7084ed

Commit

Permalink

Browse files

Browse the repository at this point in the history

tty: mark Siemens R3964 line discipline as BROKEN

The n_r3964 line discipline driver was written in a different time, when SMP machines were rare, and users were trusted to do the right thing. Since then, the world has moved on but not this code, it has stayed rooted in the past with its lovely hand-crafted list structures and loads of “interesting” race conditions all over the place.

After attempting to clean up most of the issues, I just gave up and am now marking the driver as BROKEN so that hopefully someone who has this hardware will show up out of the woodwork (I know you are out there!) and will help with debugging a raft of changes that I had laying around for the code, but was too afraid to commit as odds are they would break things.

Many thanks to Jann and Linus for pointing out the initial problems in this codebase, as well as many reviews of my attempts to fix the issues. It was a case of whack-a-mole, and as you can see, the mole won.

Reported-by: Jann Horn [email protected] Signed-off-by: Greg Kroah-Hartman [email protected] Signed-off-by: Linus Torvalds [email protected]

• Loading branch information