Headline
CVE-2022-4582: Security improvements have been implemented - about html atributes es… · ivantcholakov/starter-public-edition-4@2606983
A vulnerability was found in starter-public-edition-4 up to 4.6.10. It has been classified as problematic. Affected is an unknown function. The manipulation leads to cross site scripting. It is possible to launch the attack remotely. Upgrading to version 4.6.11 is able to address this issue. The name of the patch is 2606983c20f6ea3430ac4b36b3d2e88aafef45da. It is recommended to upgrade the affected component. The identifier of this vulnerability is VDB-216168.
@@ -189,13 +189,13 @@ function form_open($action = '’, $attributes = array(), $hidden = array())
$attributes .= ' accept-charset="’.strtolower(config_item(‘charset’)).’"’;
}
$form = '<form action="’.$action.’"’.$attributes.">\n";
$form = '<form action="’.html_attr_escape(get_instance()->security->xss_clean($action)).’"’.$attributes.">\n";
if (is_array($hidden))
{
foreach ($hidden as $name => $value)
{
$form .= '<input type="hidden" name="’.$name.’" value="’.form_prep($value).’" />’."\n";
$form .= '<input type="hidden" name="’.html_attr_escape($name).’" value="’.form_prep($value).’" />’."\n";
}
}
@@ -359,7 +359,7 @@ function form_hidden($name, $value = '’, $recursing = FALSE)
if ( ! is_array($value))
{
$form .= '<input type="hidden" name="’.$name.’" value="’.form_prep($value)."\" />\n";
$form .= '<input type="hidden" name="’.html_attr_escape($name).’" value="’.form_prep($value)."\" />\n";
}
else
{
@@ -480,7 +480,7 @@ function form_dropdown($data = '’, $options = array(), $selected = array(), $ext
continue;
}
$form .= '<optgroup label="’.$key."\">\n";
$form .= '<optgroup label="’.html_attr_escape($key)."\">\n";
foreach ($val as $optgroup_key => $optgroup_val)
{
@@ -614,14 +614,16 @@ function _parse_form_attributes($attributes, $default)
{
if ($key === ‘value’)
{
$val = form_prep($val);
$att .= get_instance()->security->xss_clean($key).’="’.form_prep($val).’" ';
}
elseif ($key === ‘name’ && ! strlen($default[‘name’]))
{
continue;
}
$att .= $key.’="’.$val.’" ';
else
{
$att .= get_instance()->security->xss_clean($key).’="’.html_attr_escape($val).’" ';
}
}
return $att;
@@ -630,3 +632,23 @@ function _parse_form_attributes($attributes, $default)
// ------------------------------------------------------------------------
// End BC functions
// Added by Ivan Tcholakov, 05-SEP-2022.
if ( ! function_exists(‘_attributes_to_string’))
{
function _attributes_to_string($attributes)
{
if (empty($attributes))
{
return '’;
}
if (is_array($attributes) || is_string($attributes) || is_object($attributes))
{
return html_attr($attributes, false);
}
return FALSE;
}
}