Headline
CVE-2023-39348: fix(gha): Fix github status log and add tests by jasonmcintosh · Pull Request #1316 · spinnaker/echo
Spinnaker is an open source, multi-cloud continuous delivery platform. Log output when updating GitHub status is improperly set to FULL always. It’s recommended to apply the patch and rotate the GitHub token used for github status notifications. Given that this would output github tokens to a log system, the risk is slightly higher than a “low” since token exposure could grant elevated access to repositories outside of control. If using READ restricted tokens, the exposure is such that the token itself could be used to access resources otherwise restricted from reads. This only affects users of GitHub Status Notifications. This issue has been addressed in pull request 1316. Users are advised to upgrade. Users unable to upgrade should disable GH Status Notifications, Filter their logs for Echo log data and use read-only tokens that are limited in scope.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes output logs when using github status checks
Co-authored-by: David Byron [email protected]
backport 1.30 1.31 1.29 1.28
❌ No backport have been created
- Backport to branch 1.30 failed
GitHub error: Branch not found
- Backport to branch 1.31 failed
GitHub error: Branch not found
- Backport to branch 1.29 failed
GitHub error: Branch not found
- Backport to branch 1.28 failed
GitHub error: Branch not found
backport release-1.30 release-1.31 release-1.29 release-1.28
❌ No backport have been created
- Backport to branch release-1.30 failed
GitHub error: Branch not found
- Backport to branch release-1.31 failed
GitHub error: Branch not found
- Backport to branch release-1.29 failed
GitHub error: Branch not found
- Backport to branch release-1.28 failed
GitHub error: Branch not found
mergify bot pushed a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
mergify bot pushed a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
mergify bot pushed a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
This was referenced
Aug 4, 2023
mergify bot pushed a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
mergify bot added a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
Co-authored-by: Jason [email protected]
mergify bot added a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
Co-authored-by: Jason [email protected]
mergify bot added a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
Co-authored-by: Jason [email protected]
mergify bot added a commit that referenced this pull request
Aug 4, 2023
* fix(gha): Fix github status log and add tests
* chore(language): Update test message to be better
Co-authored-by: David Byron [email protected]
Co-authored-by: David Byron [email protected] (cherry picked from commit 7d8130d)
Co-authored-by: Jason [email protected]
Related news
### Impact ONLY IMPACTS those use GitHub Status Notifications Log output when updating GitHub status is improperly set to FULL always. It's recommended to apply the patch and rotate the GitHub token used for github status notifications. Given that this would output github tokens to a log system, the risk is slightly higher than a "low" since token exposure could grant elevated access to repositories outside of control. If using READ restricted tokens, the exposure is such that the token itself could be used to access resources otherwise restricted from reads. ### Patches Patch is in progress. https://github.com/spinnaker/echo/pull/1316 ### Workarounds Disable GH Status Notifications. Filter your logs for Echo log data. Use read-only tokens that are limited in scope. ### References sig-security in slack: https://spinnakerteam.slack.com/archives/CFN8F5UR2