CVE-2023-45899: [CVE-2023-45899] Improper Access Control in the superuser module edited by idnovate for PrestaShop

IMPORTANT NOTICE: DO NOT REPORT VULNERABILITIES SOLELY TO THE AUTHOR OR MARKETPLACE.

We urge you to report any vulnerabilities directly to us. Our mission is to ensure the safety and security of the PrestaShop ecosystem. Unfortunately, many module developers may not always recognize or acknowledge the vulnerabilities in their code, whether due to lack of awareness, or inability to properly evaluate the associated risk, or other reasons.

Given the rise in professional cybercrime networks actively seeking out these vulnerabilities, it’s crucial that any potential threats are promptly addressed and the community is informed. The most effective method to do this is by publishing a CVE, like the one provided below.

Should you discover any vulnerabilities, please report them to us at: report[@]security-presta.org or visit https://security-presta.org for more information.

Every vulnerability report helps make the community more secure, and we are profoundly grateful for any information shared with us.

The module “idnovate” for PrestaShop incorrectly restricts access to the “connect as” feature from >= 2.3.5 and < 2.4.2 lets an attacker connect as any customer account. Release 2.4.2 fixed this security issue.

Summary

• CVE ID: CVE-2023-45899
• Published at: 2023-10-26
• Advisory source: Friends-Of-Presta.org
• Platform: PrestaShop
• Product: superuser
• Impacted release: >= 2.3.5 and < 2.4.2 (2.4.2 fixed issue)
• Product author: idnovate
• Weakness: CWE-305 CWE-639
• Severity: high (7.5)

Description

Before 2.4.2, an incorrect restriction of authentication SuperUserSetuserModuleFrontController:init() could be executed with a trivial http call and exploited to be connected as a customer.

CVSS base metrics

• Attack vector: network
• Attack complexity: low
• Privilege required: none
• User interaction: none
• Scope: unchanged
• Confidentiality: high
• Integrity: none
• Availability: none

Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N

Possible malicious usage

• Personal data leaks
• Obtain customer access and potentially registered payment methods (if save credit cards enabled on a payment module)

Patch

--- 2.4.1/modules/superuser/controllers/front/setuser.php
+++ 2.4.2/modules/superuser/controllers/front/setuser.php
@@ -31,16 +31,23 @@ class SuperUserSetuserModuleFrontControl
                 case 'getPw':
                     if (Tools::getValue('id')) {
                         $customer = new Customer((int)Tools::getValue('id'));
+                        $superuser_shop = $customer->id_shop;
+                        if (!$this->isBoLogged($superuser_shop)) {
+                            die('[SUPERUSER]Not BO logged.');
+                        }
+                        if (Shop::isFeatureActive()) {
+                            $superuser_shop = Tools::getValue('shop');
+                        }
                         $params = array(
                             'id_customer' => $customer->id,
                             'secure_key' => $customer->passwd,
-                            'superuser_shop' => $customer->id_shop,
+                            'superuser_shop' => $superuser_shop,
                             'use_last_cart' => '1',
                             'superuser_token' => Tools::encrypt($customer->id.$customer->passwd),
                             'time' => date('dmYhis')
                         );
                         $link = new Link();
-                        $controller_superuser = version_compare(_PS_VERSION_, '1.5', '<') ? (Configuration::get('PS_SSL_ENABLED') ? 'https://' : 'http://').$_SERVER['HTTP_HOST'].__PS_BASE_URI__.'modules/superuser/setuser.php?'.http_build_query($params) : $this->context->link->getModuleLink('superuser', 'setuser', $params, true, null, $customer->id_shop);
+                        $controller_superuser = version_compare(_PS_VERSION_, '1.5', '<') ? (Configuration::get('PS_SSL_ENABLED') ? 'https://' : 'http://').$_SERVER['HTTP_HOST'].__PS_BASE_URI__.'modules/superuser/setuser.php?'.http_build_query($params) : $this->context->link->getModuleLink('superuser', 'setuser', $params, true, null, $superuser_shop);
                         die($controller_superuser);
                     }
                     break;
@@ -63,6 +70,10 @@ class SuperUserSetuserModuleFrontControl
             $id_customer = $order->id_customer;
         }
         $customer = new Customer((int)$id_customer);
+        $selected_customer_shop = new Shop((int)$customer->id_shop);
+        if (!$this->isBoLogged($superuser_shop)) {
+            Tools::redirect(_PS_BASE_URL_.__PS_BASE_URI__);
+        }
         $customer_secure_key = $customer->passwd;
         if (Tools::getValue('superuser_shop')) {
             $shop = new Shop((int)Tools::getValue('superuser_shop'));

Other recommandations

• It’s recommended to upgrade to the latest version of the module superuser.

Timeline

Date

Action

2022-10-11

Vulnerability found during a audit by 202 ecommerce

2023-10-12

The author confirms the vulnerability

2023-10-13

The author publishes the release 2.4.2

2023-10-09

Request a CVE ID

2023-10-25

Publication of this advisory

Links

• Author product page
• National Vulnerability Database

DISCLAIMER: The French Association Friends Of Presta (FOP) acts as an intermediary to help hosting this advisory. While we strive to ensure the information and advice provided are accurate, FOP cannot be held liable for any consequences arising from reported vulnerabilities or any subsequent actions taken.