Headline
CVE-2022-23621: XWIKI-18870: Unexpected behavior of XWiki#invokeServletAndReturnAsString · xwiki/xwiki-platform@df8bd49
XWiki Platform is a generic wiki platform offering runtime services for applications built on top of it. In affected versions any user with SCRIPT right can read any file located in the XWiki WAR (for example xwiki.cfg and xwiki.properties) through XWiki#invokeServletAndReturnAsString as $xwiki.invokeServletAndReturnAsString("/WEB-INF/xwiki.cfg"). This issue has been patched in XWiki versions 12.10.9, 13.4.3 and 13.7-rc-1. Users are advised to update. The only workaround is to limit SCRIPT right.
Expand Up @@ -35,6 +35,9 @@ import java.lang.reflect.Method; import java.lang.reflect.InvocationTargetException; import java.io.IOException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.net.smtp.SMTPClient; import org.apache.commons.net.smtp.SMTPReply; import org.apache.commons.lang3.StringUtils; Expand Down Expand Up @@ -78,6 +81,7 @@ import com.xpn.xwiki.util.Util; import com.xpn.xwiki.web.Utils; import com.xpn.xwiki.web.XWikiMessageTool; import com.xpn.xwiki.web.XWikiRequest; import com.xpn.xwiki.web.includeservletasstring.IncludeServletAsString;
/** * Add a backward compatibility layer to the {@link com.xpn.xwiki.XWiki} class. Expand Down Expand Up @@ -1388,4 +1392,24 @@ public privileged aspect XWikiCompatibilityAspect } return this.configuredSyntaxes; }
/** * Designed to include dynamic content, such as Servlets or JSPs, inside Velocity templates; works by creating a * RequestDispatcher, buffering the output, then returning it as a string. * * @deprecated since 12.10.9, 13.4.3, 13.7RC1 */ @Deprecated public String XWiki.invokeServletAndReturnAsString(String url, XWikiContext xwikiContext) { HttpServletRequest servletRequest = xwikiContext.getRequest(); HttpServletResponse servletResponse = xwikiContext.getResponse();
try { return IncludeServletAsString.invokeServletAndReturnAsString(url, servletRequest, servletResponse); } catch (Exception e) { LOGGER.warn("Exception including url: " + url, e); return “Exception including \"” + url + "\", see logs for details."; } } }