Headline
CVE-2023-36809: Sanitize test plan name in tree_view_html() · kiwitcms/Kiwi@195ea53
Kiwi TCMS, an open source test management system allows users to upload attachments to test plans, test cases, etc. Versions of Kiwi TCMS prior to 12.5 had introduced changes which were meant to serve all uploaded files as plain text in order to prevent browsers from executing potentially dangerous files when such files are accessed directly. The previous Nginx configuration was incorrect allowing certain browsers like Firefox to ignore the Content-Type: text/plain header on some occasions thus allowing potentially dangerous scripts to be executed. Additionally, file upload validators and parts of the HTML rendering code had been found to require additional sanitation and improvements. Version 12.5 fixes this vulnerability with updated Nginx content type configuration, improved file upload validation code to prevent more potentially dangerous uploads, and Sanitization of test plan names used in the tree_view_html() function.
Expand Up @@ -9,6 +9,7 @@
from tcms.core.history import KiwiHistoricalRecords from tcms.core.models.base import UrlMixin from tcms.core.templatetags.extra_filters import bleach_input from tcms.management.models import Version from tcms.testcases.models import TestCasePlan
Expand Down Expand Up @@ -213,6 +214,7 @@ def tree_view_html(self): if test_plan.pk == self.pk: active_class = “active”
plan_name = bleach_input(test_plan.name) result += f""" <!-- begin-node --> <div class="list-group-item {active_class}" style="border: none"> Expand All @@ -228,7 +230,7 @@ def tree_view_html(self): <div class="list-view-pf-description"> <div class="list-group-item-text"> <a href="{test_plan.get_absolute_url()}"> TP-{test_plan.pk}: {test_plan.name} TP-{test_plan.pk}: {plan_name} </a> </div> </div> Expand Down
Related news
### Impact Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced changes which were meant to serve all uploaded files as plain text in order to prevent browsers from executing potentially dangerous files when such files are accessed directly! The previous Nginx configuration was incorrect allowing certain browsers like Firefox to ignore the `Content-Type: text/plain` header on some occasions thus allowing potentially dangerous scripts to be executed. Additionally file upload validators and parts of the HTML rendering code have been found to require additional sanitation and improvements. ### Patches - Updated Nginx content type configuration - Improved file upload validation code to prevent more potentially dangerous uploads - Sanitization of test plan names used in the `tree_view_html()` function ### References Disclosed by [M Nadeem Qazi](https://huntr.dev/bounties/511489dd-ba38-4806-9029-b28ab2830aa8/) and ...