CVE-2023-48294: Broken Access control on Graphs Feature

Summary

This vulnerability occurs when application is not checking access of each type of users as per their role and it autorizing the users to access any feature. When user access his Device dashboard in librenms, one request is going to graph.php to access image of graphs generated on the particular Device. This request can be accessed by lower privileged users as well and they can enumerate devices on librenms with their id or hostname.

Details

Give all details on the vulnerability. Pointing to the incriminated source code is very helpful for the maintainer.

PoC

1. Login with Lower privilege user

2. Go to /graph.php?width=150&height=45&device=1&type=device_ping_perf&from=1699022192&legend=no&bg=FFFFFF00&popup_title=ICMP+Response

3. If its showing image with “device*ping_perf” which confirms that there is device with id 1

4. Now you can change device parameter in above URL with hostname to check if that Hostname/IP exist or not like
   http://127.0.0.1:8000/graph.php?width=150&height=45&device=127.0.0.1&type=device_ping_perf&from=1699022192&legend=no&bg=FFFFFF00&popup_title=ICMP+Response

5. If device hostname doesn’t exist then it should show 500 error

Check attached screenshots for more info

Vulnerable code:
https://github.com/librenms/librenms/blob/fa93034edd40c130c2ff00667ca2498d84be6e69/html/graph.php#L19C1-L25C2

Above is vulnerable line of code from Line number 19-25
This is not checking privilege of users to access any device hostname, its just checking if user is authenticated
or not

Impact

Low privilege users can see all devices registered by admin users by using this method

Solution

Implement privilege access control feature to check if low privilege user have access or not.

Screenshots:-