Headline
CVE-2022-21684: SECURITY: Do not sign in unapproved users (#15552) · discourse/discourse@584c6a2
Discourse is an open source discussion platform. Versions prior to 2.7.13 in stable, 2.8.0.beta11 in beta, and 2.8.0.beta11 in tests-passed allow some users to log in to a community before they should be able to do so. A user invited via email to a forum with must_approve_users enabled is going to be automatically logged in, bypassing the check that does not allow unapproved users to sign in. They will be able to do everything an approved user can do. If they logout, they cannot log back in. This issue is patched in the stable version 2.7.13, beta version 2.8.0.beta11, and tests-passed version 2.8.0.beta11. One may disable invites as a workaround. Administrators can increase min_trust_level_to_allow_invite to reduce the attack surface to more trusted users.
@@ -298,7 +298,7 @@ def perform_accept_invitation return render json: failed_json.merge(message: I18n.t(‘invite.not_found_json’)), status: 404 end
log_on_user(user) if user.active? log_on_user(user) if user.active? && user.guardian.can_access_forum? user.update_timezone_if_missing(params[:timezone]) post_process_invite(user) create_topic_invite_notifications(invite, user) @@ -307,14 +307,19 @@ def perform_accept_invitation response = {}
if user.present? if user.active? if user.active? && user.guardian.can_access_forum? if user.guardian.can_see?(topic) response[:redirect_to] = path(topic.relative_url) else response[:redirect_to] = path(“/”) end else response[:message] = I18n.t(‘invite.confirm_email’) response[:message] = if user.active? I18n.t(‘activation.approval_required’) else I18n.t(‘invite.confirm_email’) end
if user.guardian.can_see?(topic) cookies[:destination_url] = path(topic.relative_url) end