GHSA-99c3-qc2q-p94m: GeoTools OGC Filter SQL Injection Vulnerabilities

1. GitHub Advisory Database
2. GitHub Reviewed
3. CVE-2023-25158

GeoTools OGC Filter SQL Injection Vulnerabilities

Critical severity GitHub Reviewed Published Feb 21, 2023 in geotools/geotools • Updated Feb 22, 2023

Package

maven org.geotools:gt-jdbc (Maven)

Affected versions

>= 28.0, < 28.2

>= 27.0, < 27.4

>= 26.0, < 26.7

>= 25.0, < 25.7

< 24.7

Patched versions

28.2

27.4

26.7

25.7

24.7

Impact

GeoTools includes support for OGC Filter expression language parsing, encoding and execution against a range of datastore.

SQL Injection Vulnerabilities have been found when executing OGC Filters with JDBCDataStore implementations:

1. PropertyIsLike filter
   • Requires PostGIS DataStore with “encode functions” enabled
   • Or any JDBCDataStore (all relational databases) with String field (no mitigation)
2. strEndsWith function
   • Requires PostGIS DataStore with “encode functions” enabled
3. strStartsWith function
   • Requires PostGIS DataStore with “encode functions” enabled
4. FeatureId filter
   • Requires JDBCDataStore (all relational databases) with prepared statements disabled and table with String primary key (Oracle not affected, SQL Server and MySQL have no settings to enabled prepared statements, PostGIS does)
5. jsonArrayContains function
   • Requires PostGIS and Oracle DataStore with String or JSON field
6. DWithin filter
   • Happens only in Oracle DataStore, no mitigation

Patches

• GeoTools 28.2
• GeoTools 27.4
• GeoTools 26.7
• GeoTools 25.7
• GeoTools 24.7

Workarounds

Partial mitigation:

• In PostGIS DataStore disable “encode functions”

• In any PostGIS enable “prepared statements” (only database with such settings)

  Map<String, Object\> params = new HashMap<>();
  params.put("dbtype", "postgis");
  params.put("host", "localhost");
  params.put("port", 5432);
  params.put("schema", "public");
  params.put("database", "database");
  params.put("user", "postgres");
  params.put("passwd", "postgres");
  params.put("preparedStatements", true ); // mitigation
  params.put("encode functions", false ); // mitigation
  
  DataStore dataStore = DataStoreFinder.getDataStore(params);
  

References

• OGC Filter SQL Injection Vulnerabilities (GeoServer)

References

• GHSA-99c3-qc2q-p94m
• https://nvd.nist.gov/vuln/detail/CVE-2023-25158
• geotools/geotools@64fb4c4

Published by the National Vulnerability Database

Feb 21, 2023

Published to the GitHub Advisory Database

Feb 22, 2023

Last updated

Feb 22, 2023