Headline
GHSA-3rcq-39xp-7xjp: ic-stable-structures vulnerable to BTreeMap memory leak when deallocating nodes with overflows
Impact
When storing unbounded types in a BTreeMap, a node is represented as a linked list of "memory chunks". It was discovered recently that when we deallocate a node, in some cases only the first memory chunk is deallocated, and the rest of the memory chunks remain (incorrectly) allocated, causing a memory leak.
In the worst case, depending on how a canister uses the BTreeMap, an adversary could interact with the canister through its API and trigger interactions with the map that keep consuming memory due to the memory leak. This could potentially lead to using an excessive amount of memory, or even running out of memory.
This issue has been fixed in #212 by changing the logic for deallocating nodes to ensure that all of a node’s memory chunks are deallocated. Tests have been added to prevent regressions of this nature moving forward.
Note: Users of stable-structure < 0.6.0 are not affected.
Patches
The problem has been fixed in PR #212 and users are asked to upgrade to version 0.6.4.
Workarounds
Users who are not storing unbounded types in BTreeMap are not affected and do not need to upgrade. Otherwise, an upgrade to version 0.6.4 is necessary.
- GitHub Advisory Database
- GitHub Reviewed
- CVE-2024-4435
ic-stable-structures vulnerable to BTreeMap memory leak when deallocating nodes with overflows
Moderate severity GitHub Reviewed Published May 21, 2024 in dfinity/stable-structures • Updated May 21, 2024
Package
cargo ic-stable-structures (Rust)
Affected versions
>= 0.6.0, < 0.6.4
Impact
When storing unbounded types in a BTreeMap, a node is represented as a linked list of "memory chunks". It was discovered recently that when we deallocate a node, in some cases only the first memory chunk is deallocated, and the rest of the memory chunks remain (incorrectly) allocated, causing a memory leak.
In the worst case, depending on how a canister uses the BTreeMap, an adversary could interact with the canister through its API and trigger interactions with the map that keep consuming memory due to the memory leak. This could potentially lead to using an excessive amount of memory, or even running out of memory.
This issue has been fixed in #212 by changing the logic for deallocating nodes to ensure that all of a node’s memory chunks are deallocated. Tests have been added to prevent regressions of this nature moving forward.
Note: Users of stable-structure < 0.6.0 are not affected.
Patches
The problem has been fixed in PR #212 and users are asked to upgrade to version 0.6.4.
Workarounds
Users who are not storing unbounded types in BTreeMap are not affected and do not need to upgrade. Otherwise, an upgrade to version 0.6.4 is necessary.
References
- GHSA-3rcq-39xp-7xjp
- https://nvd.nist.gov/vuln/detail/CVE-2024-4435
- dfinity/stable-structures#212
- dfinity/stable-structures@4f6b8ae
- https://docs.rs/ic-stable-structures/0.6.4/ic_stable_structures
- https://internetcomputer.org/docs/current/developer-docs/smart-contracts/maintain/storage#stable-memory
Published to the GitHub Advisory Database
May 21, 2024
Last updated
May 21, 2024