Headline
GHSA-5r3x-p7xx-x6q5: Comrak AST node data is not validated (GHSL-2023-049)
Impact
A Comrak AST can be constructed manually by a program instead of parsing a Markdown document with parse_document. This AST can then be converted to HTML via html::format_document_with_plugins. However, the HTML formatting code assumes that the AST is well-formed. For example, many AST notes contain [u8] fields which the formatting code assumes is valid UTF-8 data. Several bugs can be triggered if this is not the case.
Patches
0.17.0 contains adjustments to the AST, storing strings instead of unvalidated byte arrays.
Workarounds
- Validate UTF-8 correctness of all data when assigning to
&[u8]andVec<u8>fields in the AST.
References
n/a
Package
cargo comrak (Rust)
Affected versions
< 0.17.0
Description
Impact
A Comrak AST can be constructed manually by a program instead of parsing a Markdown document with parse_document. This AST can then be converted to HTML via html::format_document_with_plugins. However, the HTML formatting code assumes that the AST is well-formed. For example, many AST notes contain [u8] fields which the formatting code assumes is valid UTF-8 data. Several bugs can be triggered if this is not the case.
Patches
0.17.0 contains adjustments to the AST, storing strings instead of unvalidated byte arrays.
Workarounds
- Validate UTF-8 correctness of all data when assigning to &[u8] and Vec<u8> fields in the AST.
References
n/a
References
- GHSA-5r3x-p7xx-x6q5
- kivikakk/comrak@9ff5f8d
- https://github.com/kivikakk/comrak/releases/tag/0.17.0
Published to the GitHub Advisory Database
Mar 28, 2023
Last updated
Mar 28, 2023
Related news
comrak is a CommonMark + GFM compatible Markdown parser and renderer written in rust. A Comrak AST can be constructed manually by a program instead of parsing a Markdown document with `parse_document`. This AST can then be converted to HTML via `html::format_document_with_plugins`. However, the HTML formatting code assumes that the AST is well-formed. For example, many AST notes contain `[u8]` fields which the formatting code assumes is valid UTF-8 data. Several bugs can be triggered if this is not the case. Version 0.17.0 contains adjustments to the AST, storing strings instead of unvalidated byte arrays. Users are advised to upgrade. Users unable to upgrade may manually validate UTF-8 correctness of all data when assigning to `&[u8]` and `Vec<u8>` fields in the AST. This issue is also tracked as `GHSL-2023-049`.