Headline
GHSA-pqhm-4wvf-2jg8: Missing validation results in undefined behavior in `QuantizedConv2D`
Impact
The implementation of tf.raw_ops.QuantizedConv2D
does not fully validate the input arguments:
import tensorflow as tf
input = tf.constant(1, shape=[1, 2, 3, 3], dtype=tf.quint8)
filter = tf.constant(1, shape=[1, 2, 3, 3], dtype=tf.quint8)
# bad args
min_input = tf.constant([], shape=[0], dtype=tf.float32)
max_input = tf.constant(0, shape=[], dtype=tf.float32)
min_filter = tf.constant(0, shape=[], dtype=tf.float32)
max_filter = tf.constant(0, shape=[], dtype=tf.float32)
tf.raw_ops.QuantizedConv2D(
input=input,
filter=filter,
min_input=min_input,
max_input=max_input,
min_filter=min_filter,
max_filter=max_filter,
strides=[1, 1, 1, 1],
padding="SAME")
In this case, references get bound to nullptr
for each argument that is empty (in the example, all arguments in the bad args
section).
Patches
We have patched the issue in GitHub commit 0f0b080ecde4d3dfec158d6f60da34d5e31693c4.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University.
- GitHub Advisory Database
- GitHub Reviewed
- CVE-2022-29201
Missing validation results in undefined behavior in `QuantizedConv2D`
Moderate severity GitHub Reviewed Published May 24, 2022 in tensorflow/tensorflow • Updated May 24, 2022
We are still processing this advisory. You may have affected repositories that are not yet on this list. Check back soon for more.
Package
pip tensorflow (pip )
Affected versions
< 2.6.4
>= 2.7.0, < 2.7.2
>= 2.8.0, < 2.8.1
Patched versions
2.6.4
2.7.2
2.8.1
Package
pip tensorflow-cpu (pip )
Affected versions
< 2.6.4
>= 2.7.0, < 2.7.2
>= 2.8.0, < 2.8.1
Patched versions
2.6.4
2.7.2
2.8.1
Package
pip tensorflow-gpu (pip )
Affected versions
< 2.6.4
>= 2.7.0, < 2.7.2
>= 2.8.0, < 2.8.1
Patched versions
2.6.4
2.7.2
2.8.1
Impact
The implementation of tf.raw_ops.QuantizedConv2D does not fully validate the input arguments:
import tensorflow as tf
input = tf.constant(1, shape=[1, 2, 3, 3], dtype=tf.quint8) filter = tf.constant(1, shape=[1, 2, 3, 3], dtype=tf.quint8)
# bad args min_input = tf.constant([], shape=[0], dtype=tf.float32) max_input = tf.constant(0, shape=[], dtype=tf.float32) min_filter = tf.constant(0, shape=[], dtype=tf.float32) max_filter = tf.constant(0, shape=[], dtype=tf.float32)
tf.raw_ops.QuantizedConv2D( input=input, filter=filter, min_input=min_input, max_input=max_input, min_filter=min_filter, max_filter=max_filter, strides=[1, 1, 1, 1], padding="SAME")
In this case, references get bound to nullptr for each argument that is empty (in the example, all arguments in the bad args section).
Patches
We have patched the issue in GitHub commit 0f0b080ecde4d3dfec158d6f60da34d5e31693c4.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University.
References
- GHSA-pqhm-4wvf-2jg8
- https://nvd.nist.gov/vuln/detail/CVE-2022-29201
- tensorflow/tensorflow@0f0b080
- https://github.com/tensorflow/tensorflow/blob/f3b9bf4c3c0597563b289c0512e98d4ce81f886e/tensorflow/core/kernels/quantized_conv_ops.cc
- https://github.com/tensorflow/tensorflow/releases/tag/v2.6.4
- https://github.com/tensorflow/tensorflow/releases/tag/v2.7.2
- https://github.com/tensorflow/tensorflow/releases/tag/v2.8.1
- https://github.com/tensorflow/tensorflow/releases/tag/v2.9.0
Related news
TensorFlow is an open source platform for machine learning. Prior to versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4, the implementation of `tf.raw_ops.QuantizedConv2D` does not fully validate the input arguments. In this case, references get bound to `nullptr` for each argument that is empty. Versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4 contain a patch for this issue.
TensorFlow is an open source platform for machine learning. Prior to versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4, multiple TensorFlow operations misbehave in eager mode when the resource handle provided to them is invalid. In graph mode, it would have been impossible to perform these API calls, but migration to TF 2.x eager mode opened up this vulnerability. If the resource handle is empty, then a reference is bound to a null pointer inside TensorFlow codebase (various codepaths). This is undefined behavior. Versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4 contain a patch for this issue.