Headline
GHSA-rc9w-5c64-9vqq: Missing validation results in undefined behavior in `SparseTensorDenseAdd
Impact
The implementation of tf.raw_ops.SparseTensorDenseAdd
does not fully validate the input arguments:
import tensorflow as tf
a_indices = tf.constant(0, shape=[17, 2], dtype=tf.int64)
a_values = tf.constant([], shape=[0], dtype=tf.float32)
a_shape = tf.constant([6, 12], shape=[2], dtype=tf.int64)
b = tf.constant(-0.223668531, shape=[6, 12], dtype=tf.float32)
tf.raw_ops.SparseTensorDenseAdd(
a_indices=a_indices, a_values=a_values, a_shape=a_shape, b=b)
In this case, a reference gets bound to a nullptr
during kernel execution. This is UB.
Patches
We have patched the issue in GitHub commit 11ced8467eccad9c7cb94867708be8fa5c66c730.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University.
import tensorflow as tf
a_indices = tf.constant(0, shape=[17, 2], dtype=tf.int64) a_values = tf.constant([], shape=[0], dtype=tf.float32) a_shape = tf.constant([6, 12], shape=[2], dtype=tf.int64)
b = tf.constant(-0.223668531, shape=[6, 12], dtype=tf.float32)
tf.raw_ops.SparseTensorDenseAdd( a_indices=a_indices, a_values=a_values, a_shape=a_shape, b=b)
In this case, a reference gets bound to a nullptr during kernel execution. This is UB.
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University.
Related news
TensorFlow is an open source platform for machine learning. Prior to versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4, the implementation of `tf.raw_ops.SparseTensorDenseAdd` does not fully validate the input arguments. In this case, a reference gets bound to a `nullptr` during kernel execution. This is undefined behavior. Versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4 contain a patch for this issue.
TensorFlow is an open source platform for machine learning. Prior to versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4, multiple TensorFlow operations misbehave in eager mode when the resource handle provided to them is invalid. In graph mode, it would have been impossible to perform these API calls, but migration to TF 2.x eager mode opened up this vulnerability. If the resource handle is empty, then a reference is bound to a null pointer inside TensorFlow codebase (various codepaths). This is undefined behavior. Versions 2.9.0, 2.8.1, 2.7.2, and 2.6.4 contain a patch for this issue.