Headline
GHSA-ff4q-64jc-gx98: IdentityServer Open Redirect vulnerability
Impact
It is possible for an attacker to craft malicious Urls that certain functions in IdentityServer will incorrectly treat as local and trusted. If such a Url is returned as a redirect, some browsers will follow it to a third-party, untrusted site.
Note: by itself, this vulnerability does not allow an attacker to obtain user credentials, authorization codes, access tokens, refresh tokens, or identity tokens. An attacker could however exploit this vulnerability as part of a phishing attack designed to steal user credentials.
Affected Methods
In the
DefaultIdentityServerInteractionService
, theGetAuthorizationContextAsync
method may return non-null and theIsValidReturnUrl
method may return true for malicious Urls, indicating incorrectly that they can be safely redirected to.UI code calling these two methods is the most commonly used code path that will expose the vulnerability. The default UI templates rely on this behavior in the Login, Challenge, Consent, and Account Creation pages. Customized user interface code might also rely on this behavior. The following uncommonly used APIs are also vulnerable:
The
ServerUrlExtensions.GetIdentityServerRelativeUrl
,ReturnUrlParser.ParseAsync
andOidcReturnUrlParser.ParseAsync
methods may incorrectly return non-null, and theReturnUrlParser.IsValidReturnUrl
andOidcReturnUrlParser.IsValidReturnUrl
methods may incorrectly return true for malicious Urls.
Patches
This vulnerability is fixed in the following versions of Duende.IdentityServer:
- 7.0.6
- 6.3.10
- 6.2.5
- 6.1.8
- 6.0.5
Duende.IdentityServer 5.1 and earlier and all versions of IdentityServer4 are no longer supported and will not be receiving updates.
Workarounds
If upgrading is not possible, use IUrlHelper.IsLocalUrl
from ASP.NET Core 5.0 or later to validate return Urls in user interface code in the IdentityServer host.
Impact
It is possible for an attacker to craft malicious Urls that certain functions in IdentityServer will incorrectly treat as local and trusted. If such a Url is returned as a redirect, some browsers will follow it to a third-party, untrusted site.
Note: by itself, this vulnerability does not allow an attacker to obtain user credentials, authorization codes, access tokens, refresh tokens, or identity tokens. An attacker could however exploit this vulnerability as part of a phishing attack designed to steal user credentials.
Affected Methods
In the DefaultIdentityServerInteractionService, the GetAuthorizationContextAsync method may return non-null and the IsValidReturnUrl method may return true for malicious Urls, indicating incorrectly that they can be safely redirected to.
UI code calling these two methods is the most commonly used code path that will expose the vulnerability. The default UI templates rely on this behavior in the Login, Challenge, Consent, and Account Creation pages. Customized user interface code might also rely on this behavior. The following uncommonly used APIs are also vulnerable:
The ServerUrlExtensions.GetIdentityServerRelativeUrl, ReturnUrlParser.ParseAsync and OidcReturnUrlParser.ParseAsync methods may incorrectly return non-null, and the ReturnUrlParser.IsValidReturnUrl and OidcReturnUrlParser.IsValidReturnUrl methods may incorrectly return true for malicious Urls.
Patches
This vulnerability is fixed in the following versions of Duende.IdentityServer:
- 7.0.6
- 6.3.10
- 6.2.5
- 6.1.8
- 6.0.5
Duende.IdentityServer 5.1 and earlier and all versions of IdentityServer4 are no longer supported and will not be receiving updates.
Workarounds
If upgrading is not possible, use IUrlHelper.IsLocalUrl from ASP.NET Core 5.0 or later to validate return Urls in user interface code in the IdentityServer host.
References
- GHSA-ff4q-64jc-gx98
- DuendeSoftware/IdentityServer@269ca21
- DuendeSoftware/IdentityServer@765116a
- DuendeSoftware/IdentityServer@d0d8eab
- DuendeSoftware/IdentityServer@f04cf0b
- DuendeSoftware/IdentityServer@fe817b4