Headline

GHSA-r4pg-vg54-wxx4: cert-manager ha a potential slowdown / DoS when parsing specially crafted PEM inputs

Impact

cert-manager packages which call the standard library pem.Decode() function can take a long time to process specially crafted invalid PEM data.

If an attacker is able to modify PEM data which cert-manager reads (e.g. in a Secret resource), they may be able to use large amounts of CPU in the cert-manager controller pod to effectively create a denial-of-service (DoS) vector for cert-manager in the cluster.

Secrets are limited in size to 1MiB, which reduces the impact of this issue; it was discovered through an ~856kB fuzz test input which causes pem.Decode to take roughly 750ms to reject the input on an M2 Max Macbook Pro. By way of comparison, a valid PEM-encoded 4096-bit RSA key takes roughly 70µs to parse on the same machine.

Given the required size of PEM data needed to present a realistic DoS vector, an attacker would need to create or insert many different large sized resources in the cluster, and so the best secondary defense is to ensure that sensible limits are placed via RBAC.

This issue affects all versions of cert-manager to have been released since at least v0.1.0 (since pem.Decode is core functionality for cert-manager). All supported releases are patched.

Patches

The fixed versions are v1.16.2, v1.15.4 and v1.12.14.

master branch: https://github.com/cert-manager/cert-manager/pull/7400
release-1.16 branch: https://github.com/cert-manager/cert-manager/pull/7401
release-1.15 branch: https://github.com/cert-manager/cert-manager/pull/7402
release-1.12 branch: https://github.com/cert-manager/cert-manager/pull/7403

Workarounds

Ensure that RBAC is scoped correctly in your cluster. If a user is able to modify resources containing PEM data to be able to exploit this, it’s like that those permissions are a bigger security threat than this issue - especially for Secret resources.

References

Upstream issue: https://github.com/golang/go/issues/50116
Similar issue: https://github.com/sigstore/sigstore/issues/198
Google OSSFuzz: https://issues.oss-fuzz.com/issues/376728466

1 month ago

ghsa

Open in Source

#mac #google #dos #git #kubernetes

GitHub Advisory Database
GitHub Reviewed
GHSA-r4pg-vg54-wxx4

cert-manager ha a potential slowdown / DoS when parsing specially crafted PEM inputs

Moderate severity GitHub Reviewed Published Nov 20, 2024 in cert-manager/cert-manager • Updated Nov 20, 2024

Package

gomod github.com/cert-manager/cert-manager (Go)

Affected versions

< 1.12.14

>= 1.13.0-alpha.0, < 1.15.4

>= 1.16.0-alpha.0, < 1.16.2

Patched versions

1.12.14

1.15.4

1.16.2

Impact

cert-manager packages which call the standard library pem.Decode() function can take a long time to process specially crafted invalid PEM data.

Secrets are limited in size to 1MiB, which reduces the impact of this issue; it was discovered through an ~856kB fuzz test input which causes pem.Decode to take roughly 750ms to reject the input on an M2 Max Macbook Pro. By way of comparison, a valid PEM-encoded 4096-bit RSA key takes roughly 70µs to parse on the same machine.

This issue affects all versions of cert-manager to have been released since at least v0.1.0 (since pem.Decode is core functionality for cert-manager). All supported releases are patched.

Patches

The fixed versions are v1.16.2, v1.15.4 and v1.12.14.