Headline
GHSA-m52v-24p8-654f: SurrealDB has an Uncaught Exception Sorting Tables by Random Order
Sorting table records using an ORDER BY clause with the rand() function as sorting mechanism could cause a panic due to relying on a comparison function that did not implement total order. This event resulted in a panic due to a recent change in Rust 1.81.
Impact
A client that is authorized to run queries in a SurrealDB server would be able to query a table with ORDER BY rand() in order to potentially cause a panic in the sorting function. This would crash the server, leading to denial of service.
Patches
The sorting algorithm has been updated to guarantee total order when shuffling records.
- Version 2.1.0 and later are not affected by this issue.
Workarounds
Affected users who are unable to update may want to limit the ability of untrusted clients to run arbitrary SurrealQL queries in the affected versions of SurrealDB. To limit the impact of the denial of service, SurrealDB administrators may also want to ensure that the SurrealDB process is running so that it can be automatically re-started after a crash.
References
- https://github.com/surrealdb/surrealdb/issues/4969
- https://github.com/surrealdb/surrealdb/pull/4989
- https://github.com/surrealdb/surrealdb/pull/4805
- https://github.com/surrealdb/surrealdb/pull/4906
- GitHub Advisory Database
- GitHub Reviewed
- GHSA-m52v-24p8-654f
SurrealDB has an Uncaught Exception Sorting Tables by Random Order
Moderate severity GitHub Reviewed Published Nov 22, 2024 in surrealdb/surrealdb • Updated Nov 22, 2024
Package
cargo surrealdb (Rust)
Affected versions
< 2.1.0
cargo surrealdb-core (Rust)
Sorting table records using an ORDER BY clause with the rand() function as sorting mechanism could cause a panic due to relying on a comparison function that did not implement total order. This event resulted in a panic due to a recent change in Rust 1.81.
Impact
A client that is authorized to run queries in a SurrealDB server would be able to query a table with ORDER BY rand() in order to potentially cause a panic in the sorting function. This would crash the server, leading to denial of service.
Patches
The sorting algorithm has been updated to guarantee total order when shuffling records.
- Version 2.1.0 and later are not affected by this issue.
Workarounds
Affected users who are unable to update may want to limit the ability of untrusted clients to run arbitrary SurrealQL queries in the affected versions of SurrealDB. To limit the impact of the denial of service, SurrealDB administrators may also want to ensure that the SurrealDB process is running so that it can be automatically re-started after a crash.
References
- surrealdb/surrealdb#4969
- surrealdb/surrealdb#4989
- surrealdb/surrealdb#4805
- surrealdb/surrealdb#4906
References
- GHSA-m52v-24p8-654f
- surrealdb/surrealdb#4969
- surrealdb/surrealdb#4805
- surrealdb/surrealdb#4906
- surrealdb/surrealdb#4989
Published to the GitHub Advisory Database
Nov 22, 2024
Last updated
Nov 22, 2024