Headline
GHSA-vp68-2wrm-69qm: matrix-sdk-crypto contains potential impersonation via room key forward responses
Impact
When matrix-rust-sdk before 0.6 requests a room key from our devices, it correctly accepts key forwards only if they are a response to a previous request. However, it doesn’t check that the device that responded matches the device the key was requested from.
This allows a malicious homeserver to insert room keys of questionable validity into the key store in some situations, potentially assisting in an impersonation attack. Note that even if key injection succeeds in this way, all forwarded keys have the imported flag set, which is used as an indicator that such keys have lesser authentication properties (and should be marked as such in clients, e.g. with a grey shield besides the message).
For more information
If you have any questions or comments about this advisory, e-mail us at [email protected].
Impact
When matrix-rust-sdk before 0.6 requests a room key from our devices, it correctly accepts key forwards only if they are a response to a previous request. However, it doesn’t check that the device that responded matches the device the key was requested from.
This allows a malicious homeserver to insert room keys of questionable validity into the key store in some situations, potentially assisting in an impersonation attack. Note that even if key injection succeeds in this way, all forwarded keys have the imported flag set, which is used as an indicator that such keys have lesser authentication properties (and should be marked as such in clients, e.g. with a grey shield besides the message).
For more information
If you have any questions or comments about this advisory, e-mail us at [email protected].
References
- GHSA-vp68-2wrm-69qm
- https://nvd.nist.gov/vuln/detail/CVE-2022-39252
- matrix-org/matrix-rust-sdk@093fb5d
- matrix-org/matrix-rust-sdk@41449d2
- https://github.com/matrix-org/matrix-rust-sdk/releases/tag/matrix-sdk-0.6.0
Related news
matrix-rust-sdk is an implementation of a Matrix client-server library in Rust, and matrix-sdk-crypto is the Matrix encryption library. Prior to version 0.6, when a user requests a room key from their devices, the software correctly remembers the request. When the user receives a forwarded room key, the software accepts it without checking who the room key came from. This allows homeservers to try to insert room keys of questionable validity, potentially mounting an impersonation attack. Version 0.6 fixes this issue.