Headline
GHSA-x7c2-7wvg-jpx7: kiwitcms vulnerable to stored XSS via unrestricted files upload
Impact
Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced upload validators in order to prevent potentially dangerous files from being uploaded, see GHSA-fwcf-753v-fgcj and Content-Security-Policy definition to prevent cross-site-scripting attacks, see GHSA-2wcr-87wf-cf9j.
The upload validation checks were not robust enough which left the possibility of an attacker to circumvent them and upload a potentially dangerous file. Exploting this flaw a combination of files could be uploaded so that they work together to circumvent the existing Content-Security-Policy and allow execution of arbitrary JavaScript in the browser.
Patches
- File upload validation code has been improved
- Kiwi TCMS will now force
Content-Type: text/plainwhen serving uploaded files
Workarounds
- Force the Content-Type header via a custom Django middleware, see
ExtraHeadersMiddlewarein https://github.com/kiwitcms/Kiwi/blob/master/tcms/core/middleware.py#L23 and/or - Force the Content-Type header via Nginx overrides, see
location /uploads/in https://github.com/kiwitcms/Kiwi/blob/master/etc/nginx.conf
References
Disclosed by Antonio Spataro and ek1ng. Additional credits to Ahmed Rabeaa Mosa.
kiwitcms vulnerable to stored XSS via unrestricted files upload
High severity GitHub Reviewed Published May 21, 2023 in kiwitcms/Kiwi • Updated May 22, 2023
Package
pip kiwitcms (pip)
Affected versions
< 12.3
Patched versions
12.3
Description
Impact
Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced upload validators in order to prevent potentially dangerous files from being uploaded, see GHSA-fwcf-753v-fgcj and Content-Security-Policy definition to prevent cross-site-scripting attacks, see GHSA-2wcr-87wf-cf9j.
The upload validation checks were not robust enough which left the possibility of an attacker to circumvent them and upload a potentially dangerous file. Exploting this flaw a combination of files could be uploaded so that they work together to circumvent the existing Content-Security-Policy and allow execution of arbitrary JavaScript in the browser.
Patches
- File upload validation code has been improved
- Kiwi TCMS will now force Content-Type: text/plain when serving uploaded files
Workarounds
- Force the Content-Type header via a custom Django middleware, see ExtraHeadersMiddleware in https://github.com/kiwitcms/Kiwi/blob/master/tcms/core/middleware.py#L23 and/or
- Force the Content-Type header via Nginx overrides, see location /uploads/ in https://github.com/kiwitcms/Kiwi/blob/master/etc/nginx.conf
References
Disclosed by Antonio Spataro and ek1ng. Additional credits to Ahmed Rabeaa Mosa.
References
- GHSA-2wcr-87wf-cf9j
- GHSA-fwcf-753v-fgcj
- GHSA-x7c2-7wvg-jpx7
- https://kiwitcms.org/blog/kiwi-tcms-team/2023/05/22/kiwi-tcms-123/
atodorov published to kiwitcms/Kiwi
May 21, 2023
Published to the GitHub Advisory Database
May 22, 2023
Reviewed
May 22, 2023
Last updated
May 22, 2023
Severity
High
8.1
/ 10
CVSS base metrics
Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
Required
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
None
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:N
Weaknesses
No CWEs
CVE ID
No known CVE
GHSA ID
GHSA-x7c2-7wvg-jpx7
Source code
kiwitcms/Kiwi
Credits
- antoniospataro Analyst
- mosaa404 Analyst
- ek1ng Analyst
Checking history
See something to contribute? Suggest improvements for this vulnerability.