Headline
CVE-2020-15260: Merge pull request from GHSA-8hcp-hm38-mfph · pjsip/pjproject@67e46c1
PJSIP is a free and open source multimedia communication library written in C language implementing standard based protocols such as SIP, SDP, RTP, STUN, TURN, and ICE. In version 2.10 and earlier, PJSIP transport can be reused if they have the same IP address + port + protocol. However, this is insufficient for secure transport since it lacks remote hostname authentication. Suppose we have created a TLS connection to sip.foo.com, which has an IP address 100.1.1.1. If we want to create a TLS connection to another hostname, say sip.bar.com, which has the same IP address, then it will reuse that existing connection, even though 100.1.1.1 does not have certificate to authenticate as sip.bar.com. The vulnerability allows for an insecure interaction without user awareness. It affects users who need access to connections to different destinations that translate to the same address, and allows man-in-the-middle attack if attacker can route a connection to another destination such as in the case of DNS spoofing.
@@ -467,6 +467,10 @@ pj_status_t create_uas_dialog( pjsip_user_agent *ua,
/* Save the remote info. */
pj_strdup(dlg->pool, &dlg->remote.info_str, &tmp);
/* Save initial destination host from transport’s info */
pj_strdup(dlg->pool, &dlg->initial_dest,
&rdata->tp_info.transport->remote_name.host);
/* Init remote’s contact from Contact header.
@@ -1192,6 +1196,12 @@ static pj_status_t dlg_create_request_throw( pjsip_dialog *dlg,
return status;
}
/* Copy the initial destination host to tdata. This information can be
* used later by transport for transport selection.
*/
if (dlg->initial_dest.slen)
pj_strdup(tdata->pool, &tdata->dest_info.name, &dlg->initial_dest);
/* Done. */
*p_tdata = tdata;
@@ -1822,6 +1832,11 @@ static void dlg_update_routeset(pjsip_dialog *dlg, const pjsip_rx_data *rdata)
* transaction as the initial transaction that establishes dialog.
*/
if (dlg->role == PJSIP_ROLE_UAC) {
/* Save initial destination host from transport’s info. */
if (!dlg->initial_dest.slen) {
pj_strdup(dlg->pool, &dlg->initial_dest,
&rdata->tp_info.transport->remote_name.host);
}
/* Ignore subsequent request from remote */
if (msg->type != PJSIP_RESPONSE_MSG)