Headline
CVE-2022-23494: Merge pull request from GHSA-gg8r-xjwq-4w92 · tinymce/tinymce@6923d85
tinymce is an open source rich text editor. A cross-site scripting (XSS) vulnerability was discovered in the alert and confirm dialogs when these dialogs were provided with malicious HTML content. This can occur in plugins that use the alert or confirm dialogs, such as in the image plugin, which presents these dialogs when certain errors occur. The vulnerability allowed arbitrary JavaScript execution when an alert presented in the TinyMCE UI for the current user. This vulnerability has been patched in TinyMCE 5.10.7 and TinyMCE 6.3.1 by ensuring HTML sanitization was still performed after unwrapping invalid elements. Users are advised to upgrade to either 5.10.7 or 6.3.1. Users unable to upgrade may ensure the the images_upload_handler returns a valid value as per the images_upload_handler documentation.
@@ -184,4 +184,41 @@ describe('headless.tinymce.themes.silver.window.WindowManagerAlertTest’, () => { Mouse.clickOn(SugarBody.body(), '.tox-button:contains(“OK”)'); UiFinder.notExists(SugarBody.body(), '[role="dialog"]'); });
it('TINY-3548: sanitize message’, async () => { createAlert('<a href="javascript:alert(1)">invalid link</a><script>alert(1)</script><a href="http://tiny.cloud">valid link</a>’, Fun.noop); const dialogBody = SelectorFind.descendant(SugarDocument.getDocument(), ‘.tox-dialog__body’).getOrDie(‘Cannot find dialog body element’); Assertions.assertStructure('A basic alert dialog should have these components’, ApproxStructure.build((s, str, arr) => s.element('div’, { classes: [ arr.has(‘tox-dialog__body’) ], children: [ s.element('div’, { classes: [ arr.has(‘tox-dialog__body-content’) ], children: [ s.element('p’, { children: [ s.element('a’, { exactAttrs: { }, children: [ s.text(str.is(‘invalid link’)) ] }), s.element('a’, { exactAttrs: { href: str.is(‘http://tiny.cloud’) }, children: [ s.text(str.is(‘valid link’)) ] }) ] }) ] }) ] })), dialogBody ); await pTeardown(); }); });
Related news
### Impact A cross-site scripting (XSS) vulnerability was discovered in the alert and confirm dialogs when these dialogs were provided with malicious HTML content. This can occur in plugins that use the alert or confirm dialogs, such as in the `image` plugin, which presents these dialogs when certain errors occur. The vulnerability allowed arbitrary JavaScript execution when an alert presented in the TinyMCE UI for the current user. ### Patches This vulnerability has been patched in TinyMCE 5.10.7 and TinyMCE 6.3.1 by ensuring HTML sanitization was still performed after unwrapping invalid elements. ### Fix To avoid this vulnerability: - Upgrade to TinyMCE 5.10.7 or higher for TinyMCE 5.x. - Upgrade to TinyMCE 6.3.1 or higher for TinyMCE 6.x. ### Workaround To reduce the impact of this vulnerability: - Ensure the the `images_upload_handler` returns a valid value as per the [images_upload_handler](https://www.tiny.cloud/docs/tinymce/6/file-image-upload/#images_upload_handler) document...