Cross-site Scripting (XSS) - Stored in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

**phpMyFAQ Stored Cross-site Scripting vulnerability**

Moderate severity GitHub Reviewed Published Mar 31, 2023 to the GitHub Advisory Database • Updated Mar 31, 2023

GHSA-7q9c-f2v8-j8gw: phpMyFAQ Stored Cross-site Scripting vulnerability

Cross-site Scripting (XSS) - Generic in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

**phpMyFAQ Cross-site Scripting vulnerability**

Moderate severity GitHub Reviewed Published Mar 31, 2023 to the GitHub Advisory Database • Updated Mar 31, 2023

GHSA-hp8m-g55r-9cfq: phpMyFAQ Cross-site Scripting vulnerability

Code Injection in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

**phpMyFAQ Code Injection vulnerability**

High severity GitHub Reviewed Published Mar 31, 2023 to the GitHub Advisory Database • Updated Mar 31, 2023

GHSA-6cpg-gqgq-2rrr: phpMyFAQ Code Injection vulnerability

Improper Privilege Management in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

@@ -121,6 +121,10 @@

$isSuperAdmin = Filter::filterInput(INPUT\_POST, 'is\_superadmin', FILTER\_UNSAFE\_RAW);

$isSuperAdmin = $isSuperAdmin === 'on';

  

if (!$user\->isSuperAdmin()) {

$isSuperAdmin = false;

}

  

// Sanity check

if (is\_null($userData\['email'\])) {

$message .= sprintf('<p class="alert alert-danger">%s</p>', $PMF\_LANG\['err\_noMailAdress'\]);

@@ -705,6 +709,7 @@ class="form-control">

</div\>

</div\>

  

<?php if ($user\->isSuperAdmin()) { ?>

<div class\="form-group row"\>

<div class\="col-lg-4"\></div\>

<div class\="col-lg-8"\>

@@ -716,6 +721,7 @@ class="form-control">

</div\>

</div\>

</div\>

<?php } ?>

  

</form\>

</div\>

CVE-2023-1762: fix: privilege escalation for users with insufficient permissions · thorsten/phpMyFAQ@ae6c1d8

 Code Injection in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

Skip to content

Sign up

*   *   Actions
        
        Automate any workflow
        
    *   Packages
        
        Host and manage packages
        
    *   Security
        
        Find and fix vulnerabilities
        
    *   Codespaces
        
        Instant dev environments
        
    *   Copilot
        
        Write better code with AI
        
    *   Code review
        
        Manage code changes
        
    *   Issues
        
        Plan and track work
        
    *   Discussions
        
        Collaborate outside of code
        
    
    *   Explore
    *   All features
    *   Documentation
    *   GitHub Skills
    *   Blog
    
*   *   For
    *   Enterprise
    *   Teams
    *   Startups
    *   Education
    
    *   By Solution
    *   CI/CD & Automation
    *   DevOps
    *   DevSecOps
    
    *   Case Studies
    *   Customer Stories
    *   Resources
    
*   *   GitHub Sponsors
        
        Fund open source developers
        
    
    *   The ReadME Project
        
        GitHub community articles
        
    
    *   Repositories
    *   Topics
    *   Trending
    *   Collections
    
*   Pricing

*   In this repository All GitHub
    

*   No suggested jump to results

*   In this repository All GitHub
    
*   In this user All GitHub
    
*   In this repository All GitHub
    

Sign in

Sign up

thorsten / **phpMyFAQ** Public

*   Notifications
*   Fork 237
*   Star 557
    

*   Code
*   Issues 24
*   Pull requests
*   Discussions
*   Actions
*   Projects 2
*   Security
*   Insights

More

Permalink

Browse files

fix: strip tags in comments

*   Loading branch information

thorsten committed

Feb 14, 2023

1 parent ae6c1d8 commit 128ef85

Show file tree

Hide file tree

Showing **2 changed files** with **2 additions** and **2 deletions**.

*   *   ajaxservice.php
    *   *   Comments.php

2 phpmyfaq/ajaxservice.php

Show comments View file

@@ -200,7 +200,7 @@

\->setType($type)

\->setUsername($username)

\->setEmail($mailer)

\->setComment(nl2br($comment))

\->setComment(nl2br(strip\_tags($comment)))

\->setDate($\_SERVER\['REQUEST\_TIME'\]);

  

if ($oComment\->addComment($commentEntity)) {

2 phpmyfaq/src/phpMyFAQ/Comments.php

Show comments View file

@@ -83,7 +83,7 @@ public function getComments(int $id, string $type): string

$output .= sprintf(

'<strong><a href="mailto:%s">%s</a></strong>',

$mail\->safeEmail($item\->getEmail()),

$item\->getUsername()

Strings::htmlentities($item\->getUsername())

);

$output .= sprintf(' <span class="text-muted">(%s)</span>', $date\->format($item\->getDate()));

$output .= ' </div>';

**0 comments on commit 128ef85**

Please sign in to comment.

CVE-2023-1761: fix: strip tags in comments · thorsten/phpMyFAQ@128ef85

@@ -43,9 +43,9 @@  
if ($user\->perm\->hasPermission($user\->getUserId(), 'add\_faq')) { // FAQ data $dateStart = Filter::filterInput(INPUT\_POST, 'dateStart', FILTER\_UNSAFE\_RAW); $dateEnd = Filter::filterInput(INPUT\_POST, 'dateEnd', FILTER\_UNSAFE\_RAW); $question = Filter::filterInput(INPUT\_POST, 'question', FILTER\_UNSAFE\_RAW); $dateStart = Filter::filterInput(INPUT\_POST, 'dateStart', FILTER\_SANITIZE\_SPECIAL\_CHARS); $dateEnd = Filter::filterInput(INPUT\_POST, 'dateEnd', FILTER\_SANITIZE\_SPECIAL\_CHARS); $question = Filter::filterInput(INPUT\_POST, 'question', FILTER\_SANITIZE\_SPECIAL\_CHARS); $categories = Filter::filterInputArray( INPUT\_POST, \[ @@ -55,25 +55,25 @@ \], \] ); $recordLang = Filter::filterInput(INPUT\_POST, 'lang', FILTER\_UNSAFE\_RAW); $tags = Filter::filterInput(INPUT\_POST, 'tags', FILTER\_UNSAFE\_RAW); $active = Filter::filterInput(INPUT\_POST, 'active', FILTER\_UNSAFE\_RAW); $sticky = Filter::filterInput(INPUT\_POST, 'sticky', FILTER\_UNSAFE\_RAW); $recordLang = Filter::filterInput(INPUT\_POST, 'lang', FILTER\_SANITIZE\_SPECIAL\_CHARS); $tags = Filter::filterInput(INPUT\_POST, 'tags', FILTER\_SANITIZE\_SPECIAL\_CHARS); $active = Filter::filterInput(INPUT\_POST, 'active', FILTER\_SANITIZE\_SPECIAL\_CHARS); $sticky = Filter::filterInput(INPUT\_POST, 'sticky', FILTER\_SANITIZE\_SPECIAL\_CHARS); $content = Filter::filterInput(INPUT\_POST, 'answer', FILTER\_SANITIZE\_SPECIAL\_CHARS); $keywords = Filter::filterInput(INPUT\_POST, 'keywords', FILTER\_UNSAFE\_RAW); $author = Filter::filterInput(INPUT\_POST, 'author', FILTER\_UNSAFE\_RAW); $keywords = Filter::filterInput(INPUT\_POST, 'keywords', FILTER\_SANITIZE\_SPECIAL\_CHARS); $author = Filter::filterInput(INPUT\_POST, 'author', FILTER\_SANITIZE\_SPECIAL\_CHARS); $email = Filter::filterInput(INPUT\_POST, 'email', FILTER\_VALIDATE\_EMAIL); $comment = Filter::filterInput(INPUT\_POST, 'comment', FILTER\_UNSAFE\_RAW); $comment = Filter::filterInput(INPUT\_POST, 'comment', FILTER\_SANITIZE\_SPECIAL\_CHARS); $recordId = Filter::filterInput(INPUT\_POST, 'id', FILTER\_VALIDATE\_INT); $solutionId = Filter::filterInput(INPUT\_POST, 'solution\_id', FILTER\_VALIDATE\_INT); $revisionId = Filter::filterInput(INPUT\_POST, 'revision\_id', FILTER\_VALIDATE\_INT); $changed = Filter::filterInput(INPUT\_POST, 'changed', FILTER\_UNSAFE\_RAW); $date = Filter::filterInput(INPUT\_POST, 'date', FILTER\_UNSAFE\_RAW); $notes = Filter::filterInput(INPUT\_POST, 'notes', FILTER\_UNSAFE\_RAW); $changed = Filter::filterInput(INPUT\_POST, 'changed', FILTER\_SANITIZE\_SPECIAL\_CHARS); $date = Filter::filterInput(INPUT\_POST, 'date', FILTER\_SANITIZE\_SPECIAL\_CHARS); $notes = Filter::filterInput(INPUT\_POST, 'notes', FILTER\_SANITIZE\_SPECIAL\_CHARS);  
// Permissions $permissions = \[\]; if ('all' === Filter::filterInput(INPUT\_POST, 'userpermission', FILTER\_UNSAFE\_RAW)) { if ('all' === Filter::filterInput(INPUT\_POST, 'userpermission', FILTER\_SANITIZE\_SPECIAL\_CHARS)) { $permissions += \[ 'restricted\_user' => \[ \-1, @@ -87,7 +87,7 @@ \]; }  
if ('all' === Filter::filterInput(INPUT\_POST, 'grouppermission', FILTER\_UNSAFE\_RAW)) { if ('all' === Filter::filterInput(INPUT\_POST, 'grouppermission', FILTER\_SANITIZE\_SPECIAL\_CHARS)) { $permissions += \[ 'restricted\_groups' => \[ \-1, @@ -203,7 +203,7 @@ // notify the user who added the question try { $notifyEmail = Filter::filterInput(INPUT\_POST, 'notifyEmail', FILTER\_SANITIZE\_EMAIL); $notifyUser = Filter::filterInput(INPUT\_POST, 'notifyUser', FILTER\_UNSAFE\_RAW); $notifyUser = Filter::filterInput(INPUT\_POST, 'notifyUser', FILTER\_SANITIZE\_SPECIAL\_CHARS); $notification\->sendOpenQuestionAnswered($notifyEmail, $notifyUser, $oLink\->toString()); } catch (Exception $e) { printf('<p class="alert alert-warning">%s</p>', $e\->getMessage());

CVE-2023-1759: fix: corrected sanitazing the string · thorsten/phpMyFAQ@ecbd810

@@ -17,6 +17,7 @@

  

namespace phpMyFAQ\\Helper;

  

use phpMyFAQ\\Strings;

use phpMyFAQ\\User;

  

/\*\*

@@ -58,7 +59,7 @@ public function getAllUserOptions(int $id = 1, bool $allowBlockedUsers = false):

'<option value="%d" %s>%s (%s)</option>',

$userId,

(($userId === $id) ? 'selected' : ''),

$this\->user\->getUserData('display\_name'),

Strings::htmlentities($this\->user\->getUserData('display\_name')),

$this\->user\->getLogin()

);

}

CVE-2023-1760: fix: added missing conversion to HTML entities · thorsten/phpMyFAQ@56295b5

Improper Input Validation in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

@@ -18,6 +18,7 @@ \*/  
use phpMyFAQ\\Filter; use phpMyFAQ\\Strings; use phpMyFAQ\\User; use phpMyFAQ\\User\\CurrentUser;  
@@ -171,7 +172,7 @@ <div class\="col-lg-12"\> <h2 class\="page-header"\> <i aria-hidden\="true" class\="fa fa-users fa-fw"\></i\> <?= $PMF\_LANG\['ad\_group\_deleteGroup'\] ?> "<?= $groupData\['name'\] ?>" <?= $PMF\_LANG\['ad\_group\_deleteGroup'\] ?> "<?= Strings::htmlentities($groupData\['name'\]) ?>" </h2\> </div\> </header\> @@ -226,8 +227,8 @@ $user = new User($faqConfig); $message = ''; $messages = \[\]; $groupName = Filter::filterInput(INPUT\_POST, 'group\_name', FILTER\_UNSAFE\_RAW, ''); $groupDescription = Filter::filterInput(INPUT\_POST, 'group\_description', FILTER\_UNSAFE\_RAW, ''); $groupName = Filter::filterInput(INPUT\_POST, 'group\_name', FILTER\_SANITIZE\_SPECIAL\_CHARS, ''); $groupDescription = Filter::filterInput(INPUT\_POST, 'group\_description', FILTER\_SANITIZE\_SPECIAL\_CHARS, ''); $groupAutoJoin = Filter::filterInput(INPUT\_POST, 'group\_auto\_join', FILTER\_UNSAFE\_RAW, ''); $csrfOkay = true; $csrfToken = Filter::filterInput(INPUT\_POST, 'csrf', FILTER\_UNSAFE\_RAW); @@ -236,7 +237,7 @@ $csrfOkay = false; } // check group name if ($groupName == '') { if ($groupName ==\= '') { $messages\[\] = $PMF\_LANG\['ad\_group\_error\_noName'\]; } // ok, let's go @@ -336,60 +337,6 @@ <?php }  
// Import LDAP groups /\* if ('import-ldap-groups' === $groupAction && $user->perm->hasPermission($user->getUserId(), 'addgroup')) { $user = new CurrentUser($faqConfig); $message = ''; $messages = \[\]; // Temporary data $groupName = 'LDAP Group'; $groupDescription = 'This is a LDAP group import demo'; $groupAutoJoin = false; $csrfOkay = true; $csrfToken = Filter::filterInput(INPUT\_POST, 'csrf', FILTER\_UNSAFE\_RAW); if (!isset($\_SESSION\['phpmyfaq\_csrf\_token'\]) || $\_SESSION\['phpmyfaq\_csrf\_token'\] !== $csrfToken) { $csrfOkay = false; } // check group name if ($groupName == '') { $messages\[\] = $PMF\_LANG\['ad\_group\_error\_noName'\]; } // ok, let's go if (count($messages) == 0 && $csrfOkay) { // create group $groupData = \[ 'name' => $groupName, 'description' => $groupDescription, 'auto\_join' => $groupAutoJoin, \]; if ($user->perm->addGroup($groupData) <= 0) { $messages\[\] = $PMF\_LANG\['ad\_adus\_dberr'\]; } } // no errors, show list if (count($messages) == 0) { $groupAction = $defaultGroupAction; $message = sprintf('<p class="alert alert-success">%s</p>', $PMF\_LANG\['ad\_group\_suc'\]); // display error messages and show form again } else { $groupAction = 'import-ldap-groups'; $message = '<p class="alert alert-danger">'; foreach ($messages as $err) { $message .= $err . '<br>'; } $message .= '</p>'; } } \*/  
// show list of users if ('list' === $groupAction) { ?> @@ -416,20 +363,6 @@  
<div class\="col-lg-4" id\="group\_list"\>  
  
<div class\="card mb-4"\> <form id\="group\_select" name\="group\_select" action\="?action=group&amp;group\_action=delete\_confirm" method\="post"\>

CVE-2023-1754: fix: added missing conversion to HTML entities, removed obsolete code · thorsten/phpMyFAQ@d773df9

Weak Password Requirements in GitHub repository thorsten/phpmyfaq prior to 3.1.12.

*   *   Actions
        
        Automate any workflow
        
    *   Packages
        
        Host and manage packages
        
    *   Security
        
        Find and fix vulnerabilities
        
    *   Codespaces
        
        Instant dev environments
        
    *   Copilot
        
        Write better code with AI
        
    *   Code review
        
        Manage code changes
        
    *   Issues
        
        Plan and track work
        
    *   Discussions
        
        Collaborate outside of code
        
    
    *   Explore
    *   All features
    *   Documentation
    *   GitHub Skills
    *   Blog
    
*   *   For
    *   Enterprise
    *   Teams
    *   Startups
    *   Education
    
    *   By Solution
    *   CI/CD & Automation
    *   DevOps
    *   DevSecOps
    
    *   Case Studies
    *   Customer Stories
    *   Resources
    
*   *   GitHub Sponsors
        
        Fund open source developers
        
    
    *   The ReadME Project
        
        GitHub community articles
        
    
    *   Repositories
    *   Topics
    *   Trending
    *   Collections
    
*   Pricing

Tag

#php