Headline
CVE-2023-35935: Merge pull request from GHSA-g8x5-p9qc-cf95 · fastify/fastify-oauth2@bff756b
@fastify/oauth2, a wrapper around the simple-oauth2 library, is vulnerable to cross site request forgery (CSRF) prior to version 7.2.0… All versions of @fastify/oauth2 used a statically generated state parameter at startup time and were used across all requests for all users. The purpose of the Oauth2 state parameter is to prevent CSRF attacks. As such, it should be unique per user and should be connected to the user’s session in some way that will allow the server to validate it. Version 7.2.0 changes the default behavior to store the state in a cookie with the http-only and same-site=lax attributes set. The state is now by default generated for every user. Note that this contains a breaking change in the checkStateFunction function, which now accepts the full Request object. There are no known workarounds for the issue.
Commit
Permalink
Browse files
Browse the repository at this point in the history
Merge pull request from GHSA-g8x5-p9qc-cf95
* feat: pass request into checkStateFunction
* feat: add state in cookies
* fix: check presence
* fix: check cookie only
* fix: change defaultGenerateStateFunction
* Update index.js
Co-authored-by: Filip Skokan [email protected]
* fix: unsign
* fix: assume stateCookie is always present
* renamed state
* fix: use session
Co-authored-by: Filip Skokan [email protected]
- Loading branch information
Related news
### Impact All versions of @fastify/oauth2 used a statically generated `state` parameter at startup time and were used across all requests for all users. The purpose of the Oauth2 `state` parameter is to prevent Cross-Site-Request-Forgery attacks. As such, it should be unique per user and should be connected to the user's session in some way that will allow the server to validate it. ### Patches v7.2.0 changes the default behavior to store the `state` in a cookie with the `http-only` and `same-site=lax` attributes set. The state is now by default generated for every user. Note that this contains a breaking change in the `checkStateFunction` function, which now accepts the full `Request` object. ### Workarounds There are no known workarounds. ### References * [Prevent Attacks and Redirect Users with OAuth 2.0 State Parameters](https://auth0.com/docs/secure/attack-protection/state-parameters)