Headline
CVE-2023-25667: Fix integer overflow for multiframe gifs. · tensorflow/tensorflow@8dc723f
TensorFlow is an open source platform for machine learning. Prior to versions 2.12.0 and 2.11.1, integer overflow occurs when 2^31 <= num_frames * height * width * channels < 2^32, for example Full HD screencast of at least 346 frames. A fix is included in TensorFlow version 2.12.0 and version 2.11.1.
@@ -105,7 +105,7 @@ uint8* Decode(const void* srcdata, int datasize, uint8* const dstdata = allocate_output(target_num_frames, width, height, channel); if (!dstdata) return nullptr; for (int k = 0; k < target_num_frames; k++) { for (ptrdiff_t k = 0; k < target_num_frames; k++) { uint8* this_dst = dstdata + k * width * channel * height;
SavedImage* this_image = &gif_file->SavedImages[k]; @@ -125,10 +125,10 @@ uint8* Decode(const void* srcdata, int datasize,
if (k > 0) { uint8* last_dst = dstdata + (k - 1) * width * channel * height; for (int i = 0; i < height; ++i) { for (ptrdiff_t i = 0; i < height; ++i) { uint8* p_dst = this_dst + i * width * channel; uint8* l_dst = last_dst + i * width * channel; for (int j = 0; j < width; ++j) { for (ptrdiff_t j = 0; j < width; ++j) { p_dst[j * channel + 0] = l_dst[j * channel + 0]; p_dst[j * channel + 1] = l_dst[j * channel + 1]; p_dst[j * channel + 2] = l_dst[j * channel + 2]; @@ -141,9 +141,9 @@ uint8* Decode(const void* srcdata, int datasize, // If the first frame does not fill the entire canvas then fill the // unoccupied canvas with zeros (black). if (k == 0) { for (int i = 0; i < height; ++i) { for (ptrdiff_t i = 0; i < height; ++i) { uint8* p_dst = this_dst + i * width * channel; for (int j = 0; j < width; ++j) { for (ptrdiff_t j = 0; j < width; ++j) { p_dst[j * channel + 0] = 0; p_dst[j * channel + 1] = 0; p_dst[j * channel + 2] = 0; @@ -165,9 +165,9 @@ uint8* Decode(const void* srcdata, int datasize, return nullptr; }
for (int i = imgTop; i < imgBottom; ++i) { for (ptrdiff_t i = imgTop; i < imgBottom; ++i) { uint8* p_dst = this_dst + i * width * channel; for (int j = imgLeft; j < imgRight; ++j) { for (ptrdiff_t j = imgLeft; j < imgRight; ++j) { GifByteType color_index = this_image->RasterBits[(i - img_desc->Top) * (img_desc->Width) + (j - img_desc->Left)];
Related news
Vulnerability in the Oracle Hyperion Financial Reporting product of Oracle Hyperion (component: Repository). The supported version that is affected is 11.2.13.0.000. Easily exploitable vulnerability allows low privileged attacker with network access via HTTP to compromise Oracle Hyperion Financial Reporting. While the vulnerability is in Oracle Hyperion Financial Reporting, attacks may significantly impact additional products (scope change). Successful attacks of this vulnerability can result in unauthorized access to critical data or complete access to all Oracle Hyperion Financial Reporting accessible data and unauthorized ability to cause a partial denial of service (partial DOS) of Oracle Hyperion Financial Reporting. CVSS 3.1 Base Score 8.5 (Confidentiality and Availability impacts). CVSS Vector: (CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:N/A:L).
### Impact Integer overflow occurs when 2^31 <= num_frames * height * width * channels < 2^32, for example Full HD screencast of at least 346 frames. ```python import urllib.request dat = urllib.request.urlopen('https://raw.githubusercontent.com/tensorflow/tensorflow/1c38ad9b78ffe06076745a1ee00cec42f39ff726/tensorflow/core/lib/gif/testdata/3g_multiframe.gif').read() import tensorflow as tf tf.io.decode_gif(dat) ``` ### Patches We have patched the issue in GitHub commit [8dc723fcdd1a6127d6c970bd2ecb18b019a1a58d](https://github.com/tensorflow/tensorflow/commit/8dc723fcdd1a6127d6c970bd2ecb18b019a1a58d). The fix will be included in TensorFlow 2.12.0. We will also cherrypick this commit on TensorFlow 2.11.1 ### For more information Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with issues and questions. ### Attribution This vulnerability has been reported by ...