Headline
GHSA-86xf-2mgp-gv3g: starcitizentools/citizen-skin allows stored XSS in search no result messages
Summary
The citizen-search-noresults-title and citizen-search-noresults-desc system messages are inserted into raw HTML, allowing anybody who can edit those messages to insert arbitrary HTML into the DOM.
Details
The system messages are inserted as raw HTML by the mustache template: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/407052e7069bdeae927d6f1a2a1c9a45b473bf9a/resources/skins.citizen.search/templates/TypeaheadPlaceholder.mustache#L8-L9
PoC
- Edit
citizen-search-noresults-titleandcitizen-search-noresults-descto<img src="" onerror="alert('citizen-search-noresults-title')">and<img src="" onerror="alert('citizen-search-noresults-desc')">(script tags don’t work here due to the way the HTML is inserted) - Open the search bar and search for a page that doesn’t exist to get the “no results” messages to show up
Impact
This impacts wikis where a group has the editinterface but not the editsitejs user right.
Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.